From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12618 invoked by alias); 8 Oct 2010 18:54:24 -0000 Received: (qmail 12605 invoked by uid 22791); 8 Oct 2010 18:54:22 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Oct 2010 18:54:16 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o98IsEBM024568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Oct 2010 14:54:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o98IsDVB027316; Fri, 8 Oct 2010 14:54:14 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o98IsCSr027011; Fri, 8 Oct 2010 14:54:12 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 9223C379C20; Fri, 8 Oct 2010 12:54:11 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/2] Fix overload resolution of int* vs void* References: <4C7BCD42.9070308@redhat.com> <4CAF6546.4070603@redhat.com> Date: Fri, 08 Oct 2010 18:54:00 -0000 In-Reply-To: <4CAF6546.4070603@redhat.com> (sami wagiaalla's message of "Fri, 08 Oct 2010 14:39:02 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00151.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> + Return 1 if so, and 0 if not. If PUBLIC is 1 then only public Sami> + ancestors ancestors are considered, and the function returns 1 only One of those "ancestors" is redundant. Sami> if (is_ancestor (base, TYPE_BASECLASS (dclass, i))) This should call do_is_ancestor. Sami> +/* Check whether BASE is an ancestor or base class or DCLASS "of DCLASS". Sami> + Return 1 if so, and 0 if not. Sami> + Note: callers may want to check for identity of the types before Sami> + calling this function -- identical types are considered to satisfy Sami> + the ancestor relationship even if they're identical. */ I know this is just copied text, but it isn't very clear. If you want to clean it up, I would appreciate it, but it isn't a requirement. Tom