From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76402-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13018 invoked by alias); 12 Nov 2010 18:36:25 -0000
Received: (qmail 12898 invoked by uid 22791); 12 Nov 2010 18:36:24 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Nov 2010 18:36:19 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oACIaHTh032620	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 12 Nov 2010 13:36:18 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oACIaG0J028337;	Fri, 12 Nov 2010 13:36:17 -0500
Received: from parfait.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oACIaFXN009354;	Fri, 12 Nov 2010 13:36:16 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] Code cleanup: New init_one_comp_unit
References: <20101107035032.GA8598@host0.dyn.jankratochvil.net>
Date: Fri, 12 Nov 2010 18:36:00 -0000
In-Reply-To: <20101107035032.GA8598@host0.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Sun, 7 Nov 2010 04:50:32 +0100")
Message-ID: <m31v6q5qs8.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00159.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> unify some code into a function, to be extended in the next patch.

Looks good to me.

Jan> +/* Initiailize basic fields of dwarf_cu CU according to DIE COMP_UNIT_DIE.  */

Typo, "Initialize".

Tom