From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6382 invoked by alias); 17 Feb 2011 15:10:38 -0000 Received: (qmail 6372 invoked by uid 22791); 17 Feb 2011 15:10:38 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_KG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 15:10:33 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1HFAUEw016461 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Feb 2011 10:10:31 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1HFAUdg030040; Thu, 17 Feb 2011 10:10:30 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1HFAT9D003547; Thu, 17 Feb 2011 10:10:30 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 68F62379689; Thu, 17 Feb 2011 08:10:29 -0700 (MST) From: Tom Tromey To: Hui Zhu Cc: gdb-patches@sourceware.org Subject: Re: RFC: move agent opcodes to common file References: Date: Thu, 17 Feb 2011 15:13:00 -0000 In-Reply-To: (Hui Zhu's message of "Thu, 17 Feb 2011 07:27:06 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00420.txt.bz2 >>>>> ">" == Hui Zhu writes: >> And I have a question is if the common/ax.def updated, will the >> ax-general.c, gdbserver/tracepoint.c and file that use the ax.h >> rebuild? Thanks -- I forgot to update the dependencies in gdbserver/Makefile.in. Maybe I should finish my patch to convert gdbserver to automake :-) gdb has automatic dependency tracking, so that part will just work. >> I want try this patch with myself but looks your add the new op >> aop_pick = 0x31, aop_rot = 0x32. Yeah, it is based on my earlier patch. It is pretty easy to apply this and fix the conflicts though. >> BTW I have use the op 31 to be the op_printf in my printf patch and >> kgtp new release version. >> If your software(I think is SystemTap, right?) that use aop_pick = >> 0x31, aop_rot = 0x32 is not release, could you let op_printf use the >> op 31? Sorry about that -- I meant to leave a gap for your opcode, but then I forgot to actually do it. I fixed this locally. While I am working on some SystemTap-related functionality, this patch is independent from that. This patch just lets us translate a few more DWARF opcodes to AX. Of these, right now GCC only actually generates DW_OP_over. I just looked at GCC and it seems that the current translation code does not handle all the uses of DW_OP_over that GCC can emit. Tom