From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [unavailable regs/locals, 01/11] registers status upwards
Date: Mon, 28 Mar 2011 21:17:00 -0000 [thread overview]
Message-ID: <m31v1rq88o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110317150627.GA15201@host1.jankratochvil.net> (Jan Kratochvil's message of "Thu, 17 Mar 2011 16:06:28 +0100")
I read this thread today. A bit late, I know, but since it impacts
post-7.3 work (I hope :-) I would like to bring it up.
Jan> In such case these functions should be `warn_unused_result' and
Jan> they should be renamed from the original functions. The original
Jan> function names should throw an exception (for the case of infcall
Jan> etc.) - if any <unavailable> code should be handled directly by the
Jan> callers the original function names can even internal_error on
Jan> <unavailable> values.
If I read correctly, we're all in agreement about this as a long term
goal.
Jan> I wanted to express general disagreement with this style expecting
Jan> preciseness and no mistakes by the developers, which is not
Jan> considered to be a "safe enterprise development style".
I think we generally agree about this too.
My understanding is that the code in 7.3 is at least as robust as
gdb-before-the-series-was-applied. That is, the changes were, if not
"fail-safe", at least "fail-compatibly".
Pedro, are you planning to implement the API changes post-7.3?
If not, could you file a bug report about it?
Tom
prev parent reply other threads:[~2011-03-28 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 13:28 Pedro Alves
2011-02-28 15:53 ` Jan Kratochvil
2011-03-16 1:40 ` Pedro Alves
2011-03-17 16:31 ` Jan Kratochvil
2011-03-17 16:48 ` Pedro Alves
2011-03-17 17:25 ` Jan Kratochvil
2011-03-17 19:15 ` Pedro Alves
2011-03-28 21:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31v1rq88o.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox