From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80493-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6879 invoked by alias); 20 Apr 2011 20:21:41 -0000
Received: (qmail 6871 invoked by uid 22791); 20 Apr 2011 20:21:40 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Apr 2011 20:21:13 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3KKL8RP023094	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 20 Apr 2011 16:21:09 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3KKL8va030573;	Wed, 20 Apr 2011 16:21:08 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3KKL6XG029341;	Wed, 20 Apr 2011 16:21:07 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id B281F37808F; Wed, 20 Apr 2011 14:21:06 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFC-v5] Handle cygwin wchar_t specifics
References: <5928.31498147479$1302882967@news.gmane.org>	<m3ei53cres.fsf@fleche.redhat.com>	<005101cbfc50$193136b0$4b93a410$%muller@ics-cnrs.unistra.fr>	<20110416162455.GA5599@host1.jankratochvil.net>	<000001cbfc7d$3f67f440$be37dcc0$%muller@ics-cnrs.unistra.fr>	<83zknpoacd.fsf@gnu.org> <21014.6501930014$1303139687@news.gmane.org>	<m3zknn7a2v.fsf@fleche.redhat.com>	<34716.7311156683$1303204711@news.gmane.org>	<m3fwpe5qg1.fsf@fleche.redhat.com>	<16656.7281041809$1303221408@news.gmane.org>	<m3wriq3zbu.fsf@fleche.redhat.com>	<420.768399681215$1303286406@news.gmane.org>
Date: Wed, 20 Apr 2011 20:21:00 -0000
In-Reply-To: <420.768399681215$1303286406@news.gmane.org> (Pierre Muller's	message of "Wed, 20 Apr 2011 09:59:31 +0200")
Message-ID: <m31v0w1xot.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00375.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   Hopefully I got it right this time...
 
Just a tiny nit left :)
Thanks for persevering.

Pierre> +  const char *result;

You can make this one just a "char *".
That will let you avoid casts in the xfree calls.

Pierre> +  error ("Unable to find a vaild charset for string conversions");

Needs _().

Ok with those changes.

Tom