From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25615 invoked by alias); 12 Apr 2014 19:23:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25604 invoked by uid 89); 12 Apr 2014 19:23:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pd0-f175.google.com Received: from mail-pd0-f175.google.com (HELO mail-pd0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Apr 2014 19:23:33 +0000 Received: by mail-pd0-f175.google.com with SMTP id x10so6567834pdj.20 for ; Sat, 12 Apr 2014 12:23:32 -0700 (PDT) X-Received: by 10.66.230.193 with SMTP id ta1mr13318666pac.29.1397330612038; Sat, 12 Apr 2014 12:23:32 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id x5sm23601418pbw.26.2014.04.12.12.23.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Apr 2014 12:23:31 -0700 (PDT) From: Doug Evans To: Andy Wingo Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 6/9] Remove Guile GDB object property mechanism References: <1397060028-18158-1-git-send-email-wingo@igalia.com> <1397060028-18158-7-git-send-email-wingo@igalia.com> Date: Sat, 12 Apr 2014 19:23:00 -0000 In-Reply-To: <1397060028-18158-7-git-send-email-wingo@igalia.com> (Andy Wingo's message of "Wed, 9 Apr 2014 18:13:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00240.txt.bz2 Andy Wingo writes: > * gdb/guile/guile-internal.h: Remove scm_gsmob / GDB_SMOB_HEAD base > type; it only served as something to which object properties could be > attached: a use case already served by Guile's own object properties. > (gdbscm_init_gsmob, gdbscm_mark_gsmob, gdbscm_mark_chained_gsmob) > (gdbscm_mark_eqable_gsmob): Remove these now-unneeded functions. > > * gdb/guile/scm-gsmob.c (gdbscm_init_gsmob, gdbscm_mark_gsmob) > (gdbscm_mark_chained_gsmob, gdbscm_mark_eqable_gsmob): Remove. > (gdbscm_gsmob_property, gdbscm_set_gsmob_property_x) > (gdbscm_gsmob_has_property_p, add_property_name) > (gdbscm_gsmob_properties): Remove these public interfaces, and remove > them from gsmob_functions. > > * gdb/guile/scm-arch.c: > * gdb/guile/scm-block.c: > * gdb/guile/scm-breakpoint.c: > * gdb/guile/scm-exception.c: > * gdb/guile/scm-frame.c: > * gdb/guile/scm-iterator.c: > * gdb/guile/scm-lazy-string.c: > * gdb/guile/scm-objfile.c: > * gdb/guile/scm-pretty-print.c: > * gdb/guile/scm-symbol.c: > * gdb/guile/scm-symtab.c: > * gdb/guile/scm-type.c: > * gdb/guile/scm-value.c: Adapt to not include a gdb_gsmob base member, > for basic gsmobs, and to not call init/mark functions. I realize I wasn't going to say anything more about changelogs, but alas the above is insufficient. My understanding of community rules, and I can imagine there being differing opinions, is that shortcuts like this are not allowed. No disagreement that some brevity would be nice, but IME the community frowns on it. [More clarity on the subject would be nice.] Each change to each file needs to be documented. E.g., * scm-arch.c (_arch_smob): Delete member base. All uses updated. or some such, depending on the change. I started out with having a simple "aux" field in gsmobs so that one could store arbitrary data with them without having to resort to object properties (storing data for an "object" in a global side table is a hack I'm not fond of). I think I'll go back to having just "aux".