From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108313 invoked by alias); 18 May 2015 06:13:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108303 invoked by uid 89); 18 May 2015 06:13:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f180.google.com Received: from mail-pd0-f180.google.com (HELO mail-pd0-f180.google.com) (209.85.192.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 18 May 2015 06:13:42 +0000 Received: by pdfh10 with SMTP id h10so135249231pdf.3 for ; Sun, 17 May 2015 23:13:40 -0700 (PDT) X-Received: by 10.66.66.46 with SMTP id c14mr30439359pat.71.1431929620243; Sun, 17 May 2015 23:13:40 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id jp10sm8790578pbb.9.2015.05.17.23.13.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 23:13:39 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 6/9] Explicit locations: introduce explicit locations References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180559.19629.88488.stgit@valrhona.uglyboxes.com> Date: Mon, 18 May 2015 06:13:00 -0000 In-Reply-To: <20150507180559.19629.88488.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 07 May 2015 11:05:59 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00454.txt.bz2 Keith Seitz writes: > This patch add support for explicit locations and switches many linespec > locations to this new location type. This patch also converts all > linespec locations entered by the user to an explicit representation > internally (thus bypassing the linespec parser when resetting the > breakpoint). > > This patch does not introduce any user-visible changes. > > > gdb/ChangeLog: > > * break-catch-throw.c (re_set_exception_catchpoint): Convert > linespec into explicit location. > * breakpoint.c (create_overlay_breakpoint): Likewise. > (create_longjmp_master_breakpoint): Likewise. > (create_std_terminate_master_breakpoint): Likewise. > (create_exception_master_breakpoint): Likewise. > (create_breakpoint): For pending explicit locations, append extra_string > to the canonical representation. > (update_static_tracepoint): Convert linespec into explicit location. > (location_to_sals): Save the string representation of the location > for pending locations which were resolved. > * linespec.c (enum offset_relative_sign): Move to location.h. > (struct line_offset): Likewise. > (struct linespec) > : Replace with ... > : ... this. > : New member. > (PARSER_EXPLICIT): New accessor macro. > (undefined_label_error): New function. > (source_file_not_found_error): New function. > (linespec_parse_basic): The parser result is now an explicit location. > Use PARSER_EXPLICIT to access it. > Use undefined_label_error. > (canonicalize_linespec): Convert canonical linespec into explicit > location. > Move string representation of location to explicit_location_to_linespec > and use it and explicit_location_to_string to save string > representations of the canonical location. > (create_sals_line_offset): `ls' contains an explicit location. > Update all references. > (convert_linespec_to_sals): Likewise. > (convert_explicit_location_to_sals): New function. > (parse_linespec): Use PARSER_EXPLICIT to access the parser > result's explicit location. > (linespec_state_constructor): Initialize is_linespec. > Use PARSER_EXPLICIT. > (linespec_parser_delete): Use PARSER_EXPLICIT to access the parser's > result. > (event_location_to_sals): For linespec locations, set is_linespec. > Handle explicit locations. > (decode_objc): 'ls' contains an explicit location now. Update all > references. > (symtabs_from_filename): Use source_file_not_found_error. > * location.c (struct event_location.u) : New member. > (initialize_explicit_location): New function. > (initialize_event_location): Initialize explicit locations. > (new_explicit_location, get_explicit_location) > (get_explicit_location_const): New functions. > (explicit_to_string_internal): New function; most of contents moved > from canonicalize_linespec. > (explicit_location_to_string): New function. > (explicit_location_to_linespec): New function. > (copy_event_location): Handle explicit locations. > (delete_event_location): Likewise. > (event_location_to_string_const): Likewise. > (event_location_empty_p): Likewise. > * location.h (enum offset_relative_sign): Move here from linespec.h. > (struct line_offset): Likewise. > (enum event_location_type): Add EXPLICIT_LOCATION. > (struct explicit_location): New structure. > (explicit_location_to_string): Declare. > (explicit_location_to_linespec): Declare. > (new_explicit_location, get_explicit_locationp > (get_explicit_location_const, initialize_explicit_location): Declare. LGTM Not something to be done now, but just curious. Do we support source file names with spaces?