From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21872 invoked by alias); 19 Apr 2011 20:28:55 -0000 Received: (qmail 21864 invoked by uid 22791); 19 Apr 2011 20:28:54 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 20:28:38 +0000 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 0495E1C00A1C; Tue, 19 Apr 2011 22:28:36 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id CCD821C000A1; Tue, 19 Apr 2011 22:28:36 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id SeU4OAvujT9b; Tue, 19 Apr 2011 22:28:35 +0200 (CEST) Received: from igel.home (ppp-88-217-114-91.dynamic.mnet-online.de [88.217.114.91]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 19 Apr 2011 22:28:35 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 56B9ECA2A0; Tue, 19 Apr 2011 22:28:35 +0200 (CEST) From: Andreas Schwab To: Marek Polacek Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/setshow.exp: fix racy tests (PR testsuite/12649) References: <4DAC6924.2000100@redhat.com> <4DAD333D.6010103@redhat.com> <4DAD8C40.30703@redhat.com> <4DADDE62.5070400@redhat.com> X-Yow: Don't SANFORIZE me!! Date: Tue, 19 Apr 2011 20:28:00 -0000 In-Reply-To: <4DADDE62.5070400@redhat.com> (Marek Polacek's message of "Tue, 19 Apr 2011 21:11:30 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00343.txt.bz2 Marek Polacek writes: > On 04/19/2011 08:46 PM, Tom Tromey wrote: >> If I revert that hunk, it still works for me. >> So, something else must be going on. > > Yes, but try running it without those "\\"s and _with_ read1() > from: > > http://sourceware.org/bugzilla/show_bug.cgi?id=12649 > > I bet you will see those FAILs afterwards. Obviously: @@ -3719,7 +3719,8 @@ board_info target exists gdb,timeout board_info target exists gdb,timeout board_info host fileid getting igel fileid -set prompt (gdb) PASS: gdb.base/setshow.exp: set prompt gdb +set prompt \(gdb\) +(gdb) PASS: gdb.base/setshow.exp: set prompt gdb Sending "set radix 11" to gdb Looking to match ""[\r\n]*(Unsupported output radix ``decimal 11''; output radix unchanged..*)[\r\n]+\(gdb\) $"; "(^FOOBAR$)$"" Message is "set radix 11" --- setshow.exp 1 Jan 2011 15:33:42 -0000 1.20 +++ setshow.exp 19 Apr 2011 20:25:09 -0000 @@ -197,7 +204,7 @@ if ![board_info target exists gdb_prompt set newprompt "\\(FooBarBaz\\)" gdb_test_multiple "set prompt (FooBarBaz) " "set prompt FooBarBaz" { - -re "$newprompt $" { + -re "\[\r\n\]$newprompt $" { pass "set prompt FooBarBaz" } } @@ -213,7 +220,7 @@ if ![board_info target exists gdb_prompt #test set prompt (gdb) gdb_test_multiple "set prompt (gdb) " "set prompt gdb" { - -re "$gdb_prompt $" { + -re "\[\r\n\]$gdb_prompt $" { pass "set prompt gdb" } } Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."