From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Berlin To: Jim Blandy Cc: Andrew Cagney , Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [RFA] Revised C++ ABI abstraction patches Date: Thu, 15 Mar 2001 19:12:00 -0000 Message-id: References: <200103150951.EAA25684@zwingli.cygnus.com> <3AB148D9.CA2A668B@cygnus.com> X-SW-Source: 2001-03/msg00270.html Jim Blandy writes: > Andrew Cagney writes: > > When Dan originally submitted his original patch it was large. > > Fortunatly it was only (mostly) the mechanical change of separating out > > the C++ stuff (it was also approved so I don't know why it wasn't > > committed). Now, however, the patch has managed to accumulate much much > > more (sigh). This really should be broken down into the mechanical > > change of creating a new file and the modifications that fix real bugs. > > I don't think this patch is really what you think it is. Perhaps it > looks that way because of the way I wrote the ChangeLog entries. I > was trying to preserve Dan's original log text, but I think if I just > write a log entry from scratch, it will make a lot more sense. But do > look at the actual patch, and I think you'll see what I mean. I'll rewrite the changelog, i'm about to submit the 4th revision of the patch, incorporating your fixes, my fixes, and my additions. > > Oh, there is one random fix in linespec.c that should be segregated. > I'll fix that. But folks are acting as if it's some kind of horrible > HP-style snowball, and that's not so. It's funny, it actually removes most of the HP snowball. --Dan