From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1908 invoked by alias); 19 Apr 2009 21:35:20 -0000 Received: (qmail 1897 invoked by uid 22791); 19 Apr 2009 21:35:19 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,J_CHICKENPOX_66 X-Spam-Check-By: sourceware.org Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 19 Apr 2009 21:35:13 +0000 Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id DBCF21C15363; Sun, 19 Apr 2009 23:39:40 +0200 (CEST) Received: from localhost (dynscan2.mnet-online.de [192.168.1.215]) by mail.m-online.net (Postfix) with ESMTP id 0CA129031D; Sun, 19 Apr 2009 23:35:10 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan2.mnet-online.de [192.168.1.215]) (amavisd-new, port 10024) with ESMTP id Y2fkjUmt8Or0; Sun, 19 Apr 2009 23:35:08 +0200 (CEST) Received: from igel.home (DSL01.83.171.162.250.ip-pool.NEFkom.net [83.171.162.250]) by mail.mnet-online.de (Postfix) with ESMTP; Sun, 19 Apr 2009 23:35:08 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 87BE210DC94; Sun, 19 Apr 2009 23:35:06 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: NAT_FILE set incorrectly in gdb/Makefile References: <838wlwii4o.fsf@gnu.org> X-Yow: .. I see TOILET SEATS... Date: Sun, 19 Apr 2009 21:35:00 -0000 In-Reply-To: <838wlwii4o.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Apr 2009 22:00:07 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00506.txt.bz2 Eli Zaretskii writes: > The problem is this line from gdb/Makefile: > > NAT_FILE= config/i386/config/i386/nm-linux64.h > > which is obviously incorrect. It looks like the culprit is this line > from configure.ac: > > sed -e '/^NAT_FILE[ ]*=/s,^NAT_FILE[ ]*=[ ]*,&config/'"${gdb_host_cpu}"'/,' Makefile.tmp > > which seems to run twice, perhaps once by configure, the other time by > config.status. But that's a guess; the truth is I have no idea why > config/i386 gets prepended twice. Does anyone see the villain? Does this help? Most likey config.status was run twice with different values of CONFIG_FILES. Andreas. 2009-04-19 Andreas Schwab * configure.ac: Only postprocess Makefile when it has just been generated; avoid changequote. Index: gdb/configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.93 diff -u -a -p -r1.93 gdb/configure.ac --- gdb/configure.ac 17 Apr 2009 17:44:04 -0000 1.93 +++ gdb/configure.ac 19 Apr 2009 21:30:07 -0000 @@ -1967,10 +1967,11 @@ dnl Autoconf doesn't provide a mechanism dnl provided by makefile fragments. dnl -changequote(,)dnl -sed -e '/^NAT_FILE[ ]*=/s,^NAT_FILE[ ]*=[ ]*,&config/'"${gdb_host_cpu}"'/,' Makefile.tmp +case " $CONFIG_FILES " in +*" Makefile "*) +sed -e '/^NAT_FILE[[ ]]*=/s,^NAT_FILE[[ ]]*=[[ ]]*,&config/'"${gdb_host_cpu}"'/,' Makefile.tmp mv -f Makefile.tmp Makefile -changequote([,])dnl +esac case x$CONFIG_HEADERS in -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."