From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86127-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3609 invoked by alias); 14 Dec 2011 12:53:21 -0000
Received: (qmail 3597 invoked by uid 22791); 14 Dec 2011 12:53:20 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Dec 2011 12:53:06 +0000
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])	by mail-out.m-online.net (Postfix) with ESMTP id 49C3D1C1DA12;	Wed, 14 Dec 2011 13:53:04 +0100 (CET)
X-Auth-Info: uqnKWt0+vocoz9nZfhewTYWMr/RAqmnyXMgYo9Jgg7g=
Received: from igel.home (ppp-88-217-105-12.dynamic.mnet-online.de [88.217.105.12])	by mail.mnet-online.de (Postfix) with ESMTPA id 9FCE01C0007B;	Wed, 14 Dec 2011 13:53:04 +0100 (CET)
Received: by igel.home (Postfix, from userid 501)	id 50FD7CA29C; Wed, 14 Dec 2011 13:53:04 +0100 (CET)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/WIP PATCH 02/14] Mask software breakpoints from memory writes too
References: <20111128153742.17761.21459.stgit@localhost6.localdomain6>	<201112132132.41317.pedro@codesourcery.com> <m2k460ovk6.fsf@igel.home>	<201112141152.33791.pedro@codesourcery.com>
X-Yow: It don't mean a THING if you ain't got that SWING!!
Date: Wed, 14 Dec 2011 12:53:00 -0000
In-Reply-To: <201112141152.33791.pedro@codesourcery.com> (Pedro Alves's	message of "Wed, 14 Dec 2011 11:52:33 +0000")
Message-ID: <m2r507jowf.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00446.txt.bz2

Pedro Alves <pedro@codesourcery.com> writes:

> Does this fix it?
>
> --- a/gdb/ppc-linux-tdep.c
> +++ b/gdb/ppc-linux-tdep.c
> @@ -218,7 +218,7 @@ ppc_linux_memory_remove_breakpoint (struct gdbarch *gdbarch,
>       program modified the code on us, so it is wrong to put back the
>       old value.  */
>    if (val == 0 && memcmp (bp, old_contents, bplen) == 0)
> -    val = target_write_memory (addr, bp_tgt->shadow_contents, bplen);
> +    val = target_write_raw_memory (addr, bp_tgt->shadow_contents, bplen);
>  
>    do_cleanups (cleanup);
>    return val;

Looks good, thanks.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."