From: Andreas Schwab <schwab@linux-m68k.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [FYI] Sort includes for files gdb/[a-f]*.[chyl].
Date: Sat, 06 Apr 2019 06:48:00 -0000 [thread overview]
Message-ID: <m2pnpzk4s6.fsf@linux-m68k.org> (raw)
In-Reply-To: <20190406011654.28798-1-tom@tromey.com> (Tom Tromey's message of "Fri, 5 Apr 2019 19:16:54 -0600")
On Apr 05 2019, Tom Tromey <tom@tromey.com> wrote:
> diff --git a/gdb/aarch64-fbsd-nat.c b/gdb/aarch64-fbsd-nat.c
> index bb187a600d0..cb4130a2844 100644
> --- a/gdb/aarch64-fbsd-nat.c
> +++ b/gdb/aarch64-fbsd-nat.c
> @@ -18,16 +18,18 @@
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> #include "defs.h"
> -#include "target.h"
>
> -#include <sys/types.h>
> -#include <sys/ptrace.h>
> +/* Standard C includes. */
> #include <machine/reg.h>
> +#include <sys/ptrace.h>
> +#include <sys/types.h>
These are not really "Standard C includes".
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2019-04-06 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 1:17 Tom Tromey
2019-04-06 6:48 ` Andreas Schwab [this message]
2019-04-06 19:29 ` John Baldwin
2019-04-06 19:36 ` Tom Tromey
2019-04-06 19:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pnpzk4s6.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox