From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71802-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 449 invoked by alias); 7 Apr 2010 06:32:07 -0000
Received: (qmail 441 invoked by uid 22791); 7 Apr 2010 06:32:06 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 06:32:02 +0000
Received: by vws14 with SMTP id 14so403195vws.0         for <gdb-patches@sourceware.org>; Tue, 06 Apr 2010 23:32:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.44.198 with HTTP; Tue, 6 Apr 2010 23:32:00 -0700 (PDT)
In-Reply-To: <1242886820451223367@unknownmsgid>
References: <1242886820451223367@unknownmsgid>
Date: Wed, 07 Apr 2010 06:32:00 -0000
Received: by 10.220.108.106 with SMTP id e42mr4091922vcp.79.1270621920216;  	Tue, 06 Apr 2010 23:32:00 -0700 (PDT)
Message-ID: <m2g6dc9ffc81004062332i772781edjc1a3ef9d761f12f4@mail.gmail.com>
Subject: Re: [RFC] Fix for Go32-v2 native woes
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00121.txt.bz2

On Tue, Apr 6, 2010 at 7:15 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
> =A0In an email to gdb list,
> I complained about go32 native GDB giving internal errors...
>
> =A0The problem is that some code in i386-tdep.c is not compatible
> with a target that supports no SSE registers.
>
> =A0I finally managed to find a fix, but it is not straightforward:
> =A0I had to add a new xml file in features/i386 directory
> specific for go32v2 target, that does not read i386-sse.xml.
> =A0I had to adapt the code in i386-tdep.c to support
> missing feature_vector and to set tdesc to
> tdesc_i386_go32v2 instead of tdesc_i386 when go32v2
> osabi was detected.
>
> =A0This allows me to use CVS GDB on DJGPP again.
>
> =A0I checked with a testsuite run on gcc-farm that nothing changed
> for at least that other target (amd64-linux).
>
> =A0Similar fixes might be required for other 'old'
> i386 targets that do not support SSE registers.
>
> =A0Comments welcome as usual!
>
> Pierre Muller
> Pascal language support maintainer for GDB
>
>
>
> 2010-04-06 =A0Pierre Muller =A0<muller@ics.u-strasbg.fr>
>
> =A0 =A0 =A0 =A0* i386-tdep.c: Add include features/i386/i386-go32v2.c.
> =A0 =A0 =A0 =A0(i386_go32_init_abi): Set TDESC field to TDESC_I386_GO32V2.
> =A0 =A0 =A0 =A0(i386_validate_tdesc_p): Do not require FEATURE_VECTOR.
> =A0 =A0 =A0 =A0Adapt code accordingly.
> =A0 =A0 =A0 =A0(i386_gdbarch_init): Set TDESC to TDESC_I386_GO32V2 if
> =A0 =A0 =A0 =A0os abi is GDB_OSABI_GO32V2.
> =A0 =A0 =A0 =A0(_initialize_i386_tdep): Call initialize_tdes_i386_go32v2 =
function.
>
> =A0 =A0 =A0 =A0* features/Makefile (WHICH): Add new i386/i386-go32v2 entr=
y.
> =A0 =A0 =A0 =A0* features/i386/i386-go32v2.xml: New file. Without SSE reg=
siters.
> =A0 =A0 =A0 =A0* features/i386/i386-go32v2.c: New generated file.
> =A0 =A0 =A0 =A0* regformats/i386/i386-go32v2.dat: New generated file.
>

This patch is incorrect. Linux runs on 32bit x86 processors without SSE.
I have a patch to support it.

--=20
H.J.