From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98693-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2562 invoked by alias); 20 Feb 2013 20:15:31 -0000
Received: (qmail 2484 invoked by uid 22791); 20 Feb 2013 20:15:25 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Feb 2013 20:15:13 +0000
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])	by mail-out.m-online.net (Postfix) with ESMTP id 3ZB9664bbNz4KK2Y;	Wed, 20 Feb 2013 21:15:10 +0100 (CET)
Received: from localhost (dynscan1.mnet-online.de [192.168.6.68])	by mail.m-online.net (Postfix) with ESMTP id 3ZB9664LKtzbcCV;	Wed, 20 Feb 2013 21:15:10 +0100 (CET)
Received: from mail.mnet-online.de ([192.168.8.180])	by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024)	with ESMTP id ELQR9hgh0ma0; Wed, 20 Feb 2013 21:15:08 +0100 (CET)
X-Auth-Info: 1zqcJXq2aG5s5PHS6PW3XfvBEJPUtT3OCD4fDzdHX7E=
Received: from igel.home (ppp-88-217-121-233.dynamic.mnet-online.de [88.217.121.233])	by mail.mnet-online.de (Postfix) with ESMTPA;	Wed, 20 Feb 2013 21:15:08 +0100 (CET)
Received: by igel.home (Postfix, from userid 501)	id F018CCA29D; Wed, 20 Feb 2013 21:15:07 +0100 (CET)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <palves@redhat.com>,  Philippe Waroquiers <philippe.waroquiers@skynet.be>,  gdb-patches@sourceware.org
Subject: Re: [patch+NEWS] Avoid false valgrind warnings on linux_ptrace_test_ret_to_nx
References: <20130220140520.GA10822@host2.jankratochvil.net>	<5124E66D.3060606@redhat.com>	<20130220152331.GA16617@host2.jankratochvil.net>
X-Yow: Yes, Private DOBERMAN!!
Date: Wed, 20 Feb 2013 20:15:00 -0000
In-Reply-To: <20130220152331.GA16617@host2.jankratochvil.net> (Jan	Kratochvil's message of "Wed, 20 Feb 2013 16:23:31 +0100")
Message-ID: <m2621mn3n8.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.93 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00543.txt.bz2

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> +  /* Below we'll mmap a non-executable page, which under Valgrind
> +     results in annoying warnings such as
> +     "Bad permissions for mapped region at address 0xfoobar".
> +     Just skip the whole test if running under Valgrind.  */
> +#ifdef HAVE_RUNNING_ON_VALGRIND
> +  if (RUNNING_ON_VALGRIND)
> +    return;
> +#endif

Wouldn't it be enough for gdb to ship with an appropriate suppression
file?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."