From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29539 invoked by alias); 12 Sep 2006 15:05:08 -0000 Received: (qmail 29525 invoked by uid 22791); 12 Sep 2006 15:05:07 -0000 X-Spam-Check-By: sourceware.org Received: from mail1.asahi-net.or.jp (HELO mail.asahi-net.or.jp) (202.224.39.197) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Sep 2006 15:05:02 +0000 Received: from mitou.ysato.dip.jp (l247150.ppp.asahi-net.or.jp [218.219.247.150]) by mail.asahi-net.or.jp (Postfix) with ESMTP id 3E58912BE5 for ; Wed, 13 Sep 2006 00:04:58 +0900 (JST) Received: from mitou.localdomain (unknown [192.168.16.2]) by mitou.ysato.dip.jp (Postfix) with ESMTP id 2A3401C18A for ; Wed, 13 Sep 2006 00:04:58 +0900 (JST) Date: Tue, 12 Sep 2006 15:05:00 -0000 Message-ID: From: Yoshinori Sato To: gdb-patches Subject: [RFC] h8300 "info registers" fix User-Agent: Wanderlust/2.15.3 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Wed_Sep_13_00:04:58_2006-1" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00054.txt.bz2 --Multipart_Wed_Sep_13_00:04:58_2006-1 Content-Type: text/plain; charset=US-ASCII Content-length: 600 A result of ccr and exr mistakes by a "info registers" of h8300 target. There was two faults. - A name of E_CCR_REGNUM is not defined with h8300_register_name. Accordingly regcache_raw_read of h8300_pseudo_regitser_read fails. - Assume size of E_PSEUDO_CCR_REGNUM by 1 byte with h8300_register_type. But assume 4 bytes from a remote target. Accordingly cannot take response of remote side to be really. I correct an issue of a thing of the patch box which I attached. The issue was corrected, but not know you whether this is good technique. -- Yoshinori Sato --Multipart_Wed_Sep_13_00:04:58_2006-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="h8300-tdep.diff" Content-Transfer-Encoding: 7bit Content-length: 2248 Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.7897 diff -u -r1.7897 ChangeLog --- ChangeLog 10 Sep 2006 16:21:03 -0000 1.7897 +++ ChangeLog 12 Sep 2006 14:51:35 -0000 @@ -1,3 +1,11 @@ +2006-09-12 Yoshinori Sato + + * h8300-tdep.c (h8300_register_name): set E_CCR_REGNUM name. + (h8300s_register_name): set E_CCR_REGNUM and E_EXR_REGNUM name. + (h8300sx_register_name): Ditto. + (h8300_register_type): E_PSEUD_CCR_REGNUM and E_PSEUD_EXR_REGNUM + size fix. + 2006-09-10 Daniel Jacobowitz PR threads/2149 Index: h8300-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/h8300-tdep.c,v retrieving revision 1.103 diff -u -r1.103 h8300-tdep.c --- h8300-tdep.c 17 Dec 2005 22:34:00 -0000 1.103 +++ h8300-tdep.c 12 Sep 2006 14:51:35 -0000 @@ -949,7 +949,7 @@ type is selected. */ static char *register_names[] = { "r0", "r1", "r2", "r3", "r4", "r5", "r6", - "sp", "", "pc", "cycles", "tick", "inst", + "sp", "gdb-ccr", "pc", "cycles", "tick", "inst", "ccr", /* pseudo register */ }; if (regno < 0 @@ -965,7 +965,7 @@ { static char *register_names[] = { "er0", "er1", "er2", "er3", "er4", "er5", "er6", - "sp", "", "pc", "cycles", "", "tick", "inst", + "sp", "dbg-ccr", "pc", "cycles", "dbg-exr", "tick", "inst", "mach", "macl", "ccr", "exr" /* pseudo registers */ }; @@ -983,7 +983,7 @@ { static char *register_names[] = { "er0", "er1", "er2", "er3", "er4", "er5", "er6", - "sp", "", "pc", "cycles", "", "tick", "inst", + "sp", "dbg-ccr", "pc", "cycles", "dbg-exr", "tick", "inst", "mach", "macl", "sbr", "vbr", "ccr", "exr" /* pseudo registers */ }; @@ -1131,11 +1131,7 @@ case E_FP_REGNUM: return builtin_type_void_data_ptr; default: - if (regno == E_PSEUDO_CCR_REGNUM) - return builtin_type_uint8; - else if (regno == E_PSEUDO_EXR_REGNUM) - return builtin_type_uint8; - else if (is_h8300hmode (current_gdbarch)) + if (is_h8300hmode (current_gdbarch)) return builtin_type_int32; else return builtin_type_int16; --Multipart_Wed_Sep_13_00:04:58_2006-1--