From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26852 invoked by alias); 5 Mar 2010 08:55:18 -0000 Received: (qmail 26819 invoked by uid 22791); 5 Mar 2010 08:55:17 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=BAYES_00,DATE_IN_PAST_06_12,SARE_SUB_ENC_UTF8,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from lo.gmane.org (HELO lo.gmane.org) (80.91.229.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Mar 2010 08:55:13 +0000 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NnTJK-0001Lg-3n for gdb-patches@sources.redhat.com; Fri, 05 Mar 2010 09:55:06 +0100 Received: from 158-147-137-39.harris.com ([158.147.137.39]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Mar 2010 09:55:06 +0100 Received: from cygwin by 158-147-137-39.harris.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Mar 2010 09:55:06 +0100 To: gdb-patches@sources.redhat.com connect(): Connection refused From: Charles Wilson Subject: Re: [RFA] defs.h: Define =?utf-8?b?R0RCX0RFRkFVTFRfVEFSR0VUX1tXSURFX11DSEFSU0VU?= for Cygwin and MingW builds Date: Fri, 05 Mar 2010 08:55:00 -0000 Message-ID: References: <20100228222702.GC29360@caradoc.them.org> <20100301103125.GB9730@calimero.vinschen.de> <20100301173054.GD5683@calimero.vinschen.de> <20100301193126.GA9416@caradoc.them.org> <20100303101601.GH17293@calimero.vinschen.de> <20100303164633.GP17293@calimero.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit User-Agent: Loom/3.14 (http://gmane.org/) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00228.txt.bz2 Corinna Vinschen redhat.com> writes: > > Otherwise, should we use USE_WIN32API rather than _WIN32? It isn't > > clear to me which is preferred. > > I really don't know. I wasn't involved in porting GDB to MingW. > I see USE_WIN32API mainly used in gdbserver.c and ser-tcp.c so far. > Guessing from the comment in configure.ac I assume that USE_WIN32API > is the way to go. Remember that _WIN32 can be defined, even on __CYGWIN__, if is #included -- so _WIN32 is not, in general, a reliable indicator of "native win32"-ness. (Conversely, if you HAVEN'T included , then on cygwin _WIN32 is not defined -- which could be a problem if you really DO want to use a native win32 api from cygwin, but the code is using _WIN32 to determine whether to do so. 'Course, if you wanted to use a native win32 api, you really should have included to get the API's declaration, but that's another story). -- Chuck