From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15823 invoked by alias); 18 May 2009 05:25:29 -0000 Received: (qmail 15798 invoked by uid 22791); 18 May 2009 05:25:26 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 May 2009 05:25:17 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1M5vLb-0001oZ-Nz for gdb-patches@sources.redhat.com; Mon, 18 May 2009 05:25:11 +0000 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 May 2009 05:25:11 +0000 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 May 2009 05:25:11 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: Python pretty-printing [6/6] Date: Mon, 18 May 2009 05:25:00 -0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit User-Agent: Loom/3.14 (http://gmane.org/) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00353.txt.bz2 Tom Tromey redhat.com> writes: > > This patch adds MI support for pretty-printing. > > An MI varobj can now have dynamic children, supplied by a Python > pretty-printer. Pretty-printing for a varobj can be disabled via an > MI request. > > This patch also adds a way for MI users to fetch only a subset of > available children. > > Finally, it adds the "python" MI feature. I must admit I did not examine all of the code very closely -- and it's probably not gonna be productive to be picking code nits in such a huge patch. I have a couple of higher-level comments: 1. From the *MI* docs it is not apparent why the 'visualizer' passed is called with varobj to get the real visualizer. Docs probably should be more explicit. 2. I am unsure about the -var-set-child-range function -- why is this an integral part of this patch? Was this tried with any frontend, and found sufficient/good? I don't think we ever reached a conclusion as to how to deal with big number of children. - Volodya