From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IEjnCSzvQmjxPwMAWB0awg (envelope-from ) for ; Fri, 06 Jun 2025 09:37:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=5tB9xV9u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 135F21E11C; Fri, 6 Jun 2025 09:37:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ECCDB1E089 for ; Fri, 6 Jun 2025 09:37:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56A9E3856951 for ; Fri, 6 Jun 2025 13:37:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56A9E3856951 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=5tB9xV9u Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062a.outbound.protection.outlook.com [IPv6:2a01:111:f403:2412::62a]) by sourceware.org (Postfix) with ESMTPS id 6462A3858C50 for ; Fri, 6 Jun 2025 13:37:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6462A3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6462A3858C50 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2412::62a ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1749217026; cv=pass; b=WIe7QLP/ZWFxgonhXWqsGCu+7IC0MBnpy+zkGMjjI5JUYIwOwx2lAU4nMhqUYogt6Ec5VK4Du/9LINTYMFag9g4OBQWqC8XsvTD9q7nvYSL8CeMnAfQMBBG0+9xmBVAzvIBCtcbhYJr1Vvr2LhJlLB34l2aOjA88GNwPxgjZ9j8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1749217026; c=relaxed/simple; bh=poV9WzKsDkBIbnb0giEQXYEcFn+SMADyWe8o+kyfb/Q=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=bVdmUvj0iKcAAFzmDob03cBAy45i4eD6DzgLnEvA3+6Z4y+le4FblruNvWuXIOu3nFZZKG9gE1baLXE2dWzCsX/577dMcx9i0lA7RrBv0jYfkBnpvo9bB9vpvJ+DMLBK74v6B5AlZbukL5sjpMbYAV723KbOQf58foLB/st0DoM= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6462A3858C50 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dgjpZ59Sv52zbBd4msu4ee9sZO0tubJ1IAYDmHrrkZMMbPZLJdvR9NJnwtWqK/6dvH4BWjD/8/OaDGv2OueJANkB4vl5K9Jt6YLH45cetk4iWXaM/ZJReXDUQ3RkSWIC26kTlxBkFZtc2UdUGidGbEcNmyxEZh6Vky1QWFPKhbO9LZMiS01BUlbpeclNAj7SyXqqrlMyy+4HCm8FLRE/S1hf1Mcy6XNq6nNozAAdwMkv6S3UWBbjCGN8g0UMMKCXFGb85F2MxmjdDusGFkq7nec/tYny8oTM7SbTRWWUwSfbyS7vCYqyuR3T2zns/FlBYzPSSL+TSqZAGA3Yqmzm3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KRvB7jTaMYkEV5m6A9zdKbvK/Kal89LXbqel0kQTago=; b=WWHOagu2M0GsO48wOgsZ8cF1WdOFPnX5uxsaCtwYIrd84uIATaLT3ijoSDwoQsjy6erIlOQIiFaypHdpdXCWQKq9dhuO8KtWnTocmsphqZScJqgX7cyzh27IX8XRxCTriCzlROJT+pZQYxR0ACJjjYliO8PyliBBjtrQK4RZaH7Jq42GXN42f/HcANHZZGqvXBAZ+oEi16LJbeZ7ez1dMhksjVKv99MlbXJFzBz95IheHKn8kWn4eGVsv697x4tPV+DOSOSdy5D6yMYzctoXT1HbXL8FDKrjEF7b0yNgw87g9V1RYHId8FYHsX5dfCBR3w/ZMLUDAd4842RXWQ5jzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=efficios.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KRvB7jTaMYkEV5m6A9zdKbvK/Kal89LXbqel0kQTago=; b=5tB9xV9u+G77nJcwdXkojcIb3LaEfVJ30SGNjvJ5CeascXkAwieytDbMIl2yaHbeJbf5mmX9IGV/ZEbptLMkGcIvBGyMi4fg+n+QjNMAIWUdMM9DeIKcHGQKOXzZbo1FHzEqkg0OLlotlyBVzsFFvsknOq/M0QVijyz6x5ATSxU= Received: from BL1PR13CA0168.namprd13.prod.outlook.com (2603:10b6:208:2bd::23) by SA1PR12MB7368.namprd12.prod.outlook.com (2603:10b6:806:2b7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.37; Fri, 6 Jun 2025 13:37:02 +0000 Received: from BN1PEPF00005FFE.namprd05.prod.outlook.com (2603:10b6:208:2bd:cafe::ed) by BL1PR13CA0168.outlook.office365.com (2603:10b6:208:2bd::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Fri, 6 Jun 2025 13:37:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN1PEPF00005FFE.mail.protection.outlook.com (10.167.243.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8792.29 via Frontend Transport; Fri, 6 Jun 2025 13:37:01 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 6 Jun 2025 08:37:00 -0500 Date: Fri, 6 Jun 2025 14:36:53 +0100 From: Lancelot SIX To: Simon Marchi CC: Subject: Re: [PATCH 4/5] gdb/amd-dbgapi: factor out require_forward_progress overload to target one inferior Message-ID: References: <20250605201657.418206-4-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250605201657.418206-4-simon.marchi@efficios.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00005FFE:EE_|SA1PR12MB7368:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ae977ab-167d-43b3-a893-08dda4ff37fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IpFpWknettY/BeG0EUSurZioL4wdYCHxvqJmdS1HMSd3b0DynunBNQaE1A4t?= =?us-ascii?Q?vT+CuDO1gJ4by5M/c/obZEAE/BFavAnvDWOmY7/7xvXjEDhJeqbkqZo5Xwj3?= =?us-ascii?Q?gbpfsFJOQZ8zqcmDDHGTWCJX30F6RKRqUBQmkrhLavatEF51jmA7tkzuXlO0?= =?us-ascii?Q?Y6IFP/jWvZV3+Qfr3CjpTiHbtHgjYsMsD9oBdXjJjK6jYCC2LDLx7zAY3wd2?= =?us-ascii?Q?HN00e0Tc1RFp5/xp9PP8pO4vMPrbztaKhNtaS+V5Vis4GytihFCo1JTZ1+ag?= =?us-ascii?Q?zUT7O+9pO5orldMYeVzEMI1PTPJPMaNnCFuCvzWWpizY6Spz2NI9cnJGA8Hl?= =?us-ascii?Q?BdPGZd5pwjJpV6oBzU0mHHMTWCmdNSmM4DA3p2ZMTAjOXNIQnAoY6lePIAlA?= =?us-ascii?Q?2CmccPBW+rXoH65B1Fju4V0vrCcOYHQv8/Wj5nZEcML0Wl67KwkRk4754v91?= =?us-ascii?Q?qZfKlO+odEwW4xeZ9C7sIV7EsOwCdUhfLUCXy4XA1m6EyTIPul85imc1mZtu?= =?us-ascii?Q?bjQdwry37wwVpwtdEnsTxupMq/QTK2D+8W7zq1wdhVYPPLCaoSX7xmQsToKu?= =?us-ascii?Q?7lLDkHZiNQciZnhL+MrNVP1hkyDtJaXM+bX9ZXRlaXlrFXbLiD2s2rMiNJAC?= =?us-ascii?Q?qsvOh8OqW26pGAG7TWmLoskzd1JrKCE/dc/xfEB965UlBtoPjdD6HAq1skCS?= =?us-ascii?Q?uPDAbyPYKwvJ/8Zu+V6EnbyZyyq6qp3EBqnvP0wJ5JKo5hDEI+P0F+R9B0/3?= =?us-ascii?Q?13Ffe6mYBth531Xk4CjPlHVAbNGS8+X9cDPwkOjmW4vr2LXJn7v94K30gQiG?= =?us-ascii?Q?S+qIuR3WmHUSYYi8QpT6hXGC2q8nxe5zo++mb634uXYg6pkjoJIIjFGh3TZ+?= =?us-ascii?Q?HGgFkTlkUdEg5CfGYLAZtCLZXww8pQ4HScyJo7rHbYlg3P9YhoT8ZRiwI9ad?= =?us-ascii?Q?2qJRZPQLpzU1p2gtuvZpcNDJuWg+glBgV/ISyBu8h0RzxCGe8cEIFTvfss6J?= =?us-ascii?Q?RGPZC+T3V8hUcyAwTMilzR6omTYh84dOodrGQMKE3g9fFA1Fy4KRztTKAyx9?= =?us-ascii?Q?JUgQk9ib8mCBjEd1Yjfd6U7WNmNAXErKlIenrWVP3J3gQmp5CiYa3QqXuwL8?= =?us-ascii?Q?4kj9GW0CTNFRYzK4M0m3OBqmfeP53CKnjtrMSGLbXa7BJlnHmlS9g3/DqPuw?= =?us-ascii?Q?upbwVm0O0wy2qxRSt5tJmjCzcSaqASYcyaWrp95qKAEjyinJVc9GkdWUf/7v?= =?us-ascii?Q?pmjx3ieqCK83xt6726rSW/CsayYgJqVQCkY+PQWfxwLfddYdCA5Ud7ih+fuz?= =?us-ascii?Q?QFITuAXpVOeTwfUFjbCZMD7GEKnGZPGXD2wC0X5/d7NROEyazqCTN0nU4Fjv?= =?us-ascii?Q?JNkBGz0xcwdPGW3gfNF0ua1LwSqgAFziARZUorMCbhDZ5tssY13Q+KjW3/8c?= =?us-ascii?Q?+FccwntSgwQqiroVFpXo471EPymLT6q22gt1rZpkMSlJOOJIZYPoqPKMcIRV?= =?us-ascii?Q?FpQv4YglVAA47P4nJgbPpk/6OpuKS+Gkt9R0?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2025 13:37:01.8848 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae977ab-167d-43b3-a893-08dda4ff37fa X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00005FFE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7368 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, Jun 05, 2025 at 04:16:27PM -0400, Simon Marchi wrote: > A following patch will want to call require_forward_progress for a given > inferior. Extract a new require_forward_progress overload from the > existing require_forward_progress function that targets a specific > inferior. Hi, This LGTM, thanks. Approved-by: Lancelot Six (amdgpu) Best, Lancelot. > > Change-Id: I54f42b83eb8443d4d91747ffbc86eaeb017f1e49 > --- > gdb/amd-dbgapi-target.c | 49 +++++++++++++++++++++++------------------ > 1 file changed, 28 insertions(+), 21 deletions(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 1ec20d1874ec..e86d7f34d0f6 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -443,6 +443,32 @@ async_event_handler_mark () > mark_async_event_handler (amd_dbgapi_async_event_handler); > } > > +/* Set forward progress requirement to REQUIRE for inferior INFO. */ > + > +static void > +require_forward_progress (amd_dbgapi_inferior_info &info, bool require) > +{ > + /* If we try to disable forward progress requirement but the target expects > + resumed threads to be committed to the target, we could wait for events > + that will never arrive. */ > + if (!require) > + gdb_assert (!info.inf->process_target ()->commit_resumed_state); > + > + gdb_assert (info.process_id != AMD_DBGAPI_PROCESS_NONE); > + > + /* Don't do unnecessary calls to amd-dbgapi to avoid polluting the logs. */ > + if (info.forward_progress_required == require) > + return; > + > + const auto progress > + = require ? AMD_DBGAPI_PROGRESS_NORMAL : AMD_DBGAPI_PROGRESS_NO_FORWARD; > + const auto status > + = amd_dbgapi_process_set_progress (info.process_id, progress); > + gdb_assert (status == AMD_DBGAPI_STATUS_SUCCESS); > + > + info.forward_progress_required = require; > +} > + > /* Set forward progress requirement to REQUIRE for all processes of PROC_TARGET > matching PTID. */ > > @@ -450,12 +476,6 @@ static void > require_forward_progress (ptid_t ptid, process_stratum_target *proc_target, > bool require) > { > - /* If we try to disable forward progress requirement but the target expects > - resumed threads to be committed to the target, we could wait for events > - that will never arrive. */ > - if (!require) > - gdb_assert (!proc_target->commit_resumed_state); > - > for (inferior *inf : all_inferiors (proc_target)) > { > if (ptid != minus_one_ptid && inf->pid != ptid.pid ()) > @@ -463,21 +483,8 @@ require_forward_progress (ptid_t ptid, process_stratum_target *proc_target, > > amd_dbgapi_inferior_info *info = get_amd_dbgapi_inferior_info (inf); > > - if (info->process_id == AMD_DBGAPI_PROCESS_NONE) > - continue; > - > - /* Don't do unnecessary calls to amd-dbgapi to avoid polluting the logs. */ > - if (info->forward_progress_required == require) > - continue; > - > - amd_dbgapi_status_t status > - = amd_dbgapi_process_set_progress > - (info->process_id, (require > - ? AMD_DBGAPI_PROGRESS_NORMAL > - : AMD_DBGAPI_PROGRESS_NO_FORWARD)); > - gdb_assert (status == AMD_DBGAPI_STATUS_SUCCESS); > - > - info->forward_progress_required = require; > + if (info->process_id != AMD_DBGAPI_PROCESS_NONE) > + require_forward_progress (*info, require); > > /* If ptid targets a single inferior and we have found it, no need to > continue. */ > -- > 2.49.0