From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16448 invoked by alias); 9 Apr 2010 00:13:31 -0000 Received: (qmail 16437 invoked by uid 22791); 9 Apr 2010 00:13:31 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SARE_MSGID_LONG45,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 00:13:27 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id o390DPT5014962 for ; Thu, 8 Apr 2010 17:13:25 -0700 Received: from pvg6 (pvg6.prod.google.com [10.241.210.134]) by wpaz5.hot.corp.google.com with ESMTP id o390DOPF008114 for ; Thu, 8 Apr 2010 17:13:24 -0700 Received: by pvg6 with SMTP id 6so1620428pvg.1 for ; Thu, 08 Apr 2010 17:13:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.247.17 with HTTP; Thu, 8 Apr 2010 17:13:23 -0700 (PDT) In-Reply-To: <201004082008.55981.sergiodj@redhat.com> References: <20100406215751.7EC1784397@ruffy.mtv.corp.google.com> <201004082008.55981.sergiodj@redhat.com> Date: Fri, 09 Apr 2010 00:13:00 -0000 Received: by 10.141.91.2 with SMTP id t2mr1260433rvl.111.1270772003807; Thu, 08 Apr 2010 17:13:23 -0700 (PDT) Message-ID: Subject: Re: [RFA] Add -s option to source command. From: Doug Evans To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org, tromey@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00214.txt.bz2 On Thu, Apr 8, 2010 at 4:08 PM, Sergio Durigan Junior wrote: > On Thursday 08 April 2010 19:49:41, Doug Evans wrote: >> On Wed, Apr 7, 2010 at 1:14 PM, Tom Tromey wrote: >> > I often wish that gdb help strings were formatted more like --help >> > output. >> > >> > Tom >> >> Something like this? >> >> @@ -1379,8 +1437,12 @@ Commands defined in this way may have up >> >> =A0 =A0source_help_text =3D xstrprintf (_("\ >> =A0Read commands from a file named FILE.\n\ >> -Optional -v switch (before the filename) causes each command in\n\ >> -FILE to be echoed as it is executed.\n\ >> +\n\ >> +Usage: source [-s] [-v] FILE\n\ >> +-s: search for the script in the source search path,\n\ >> + =A0 =A0even if FILE contains directories.\n\ >> +-v: each command in FILE is echoed as it is executed.\n\ >> +\n\ >> =A0Note that the file \"%s\" is read automatically in this way\n\ >> =A0when GDB is started."), gdbinit); >> =A0 =A0c =3D add_cmd ("source", class_support, source_command, > > I totally agree with Tom here, but I don't know if it's a good thing to c= hange > the "standard" only in this feature without converting the other GDB help > strings as well. =A0IMHO if we are going to start formatting the help str= ings > like `--help' output, then we should do it for the majority (if not all) = of > the strings. > > Anyway, my half cent here. Sure. That one might want to wait and do it en-masse I left as a given. The powers that be can decide, and I'll submit what they want.