Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <ghost@cs.msu.su>
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH 3/3] suppress notification
Date: Mon, 27 Aug 2012 21:01:00 -0000	[thread overview]
Message-ID: <k1gn65$89p$1@ger.gmane.org> (raw)
In-Reply-To: <1346060757-30130-4-git-send-email-yao@codesourcery.com>

On 27.08.2012 13:45, Yao Qi wrote:
> Hi,
> This patch is to change the existing 'suppress mechanism' to avoid
> adding endless command name comparisons to suppress corresponding MI
> notification.  This patch adds a new field 'called' in 'struct
> mi_cmd', so that each MI command has a 'suppressed' flag associated to
> it, and we don't have to compare command name anymore.

Hi Yao,

I am not 100% sure this is ideal approach. Your comment say:

> +  /* If non-null, the pointer to a flag indicates that this function is being
> +     called.  */
> +  int *called;

But in practice, this is pointer that points to notification that must be supressed when this
command is running. So, at least the comment is misleading. And if some other code will
want to check whether the current command is A, it would have to look at notification
flags.

So, at the very least, this field should have a different name, I think.

Thanks,
Volodya


  parent reply	other threads:[~2012-08-27 21:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27  9:46 [PATCH 0/3] Factor code on suppress MI notification Yao Qi
2012-08-27  9:46 ` [PATCH 1/3] add static to mi_cmds Yao Qi
2012-08-27  9:46 ` [PATCH 3/3] suppress notification Yao Qi
2012-08-27 20:20   ` Tom Tromey
2012-08-27 21:01   ` Vladimir Prus [this message]
2012-08-28  2:06     ` Tom Tromey
2012-08-28  4:50       ` Vladimir Prus
2012-08-28  7:58     ` Yao Qi
2012-08-28 11:57       ` Vladimir Prus
2012-08-28 13:09         ` Yao Qi
2012-08-28 13:40           ` Pedro Alves
2012-08-28 13:50             ` Yao Qi
2012-08-28 14:09               ` Pedro Alves
2012-08-31  8:07     ` Yao Qi
2012-08-31  8:22       ` Vladimir Prus
2012-08-31  8:49         ` [committed]: " Yao Qi
2012-08-27  9:46 ` [PATCH 2/3] new macro DEF_MI_CMD_CLI and DEF_MI_CMD_MI Yao Qi
2012-08-27 20:18   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='k1gn65$89p$1@ger.gmane.org' \
    --to=ghost@cs.msu.su \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox