From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WOebNKF7A2kw/hEAWB0awg (envelope-from ) for ; Thu, 30 Oct 2025 10:52:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=5VvpKNRD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C92721E04C; Thu, 30 Oct 2025 10:52:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59A361E04C for ; Thu, 30 Oct 2025 10:52:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF6D13858C83 for ; Thu, 30 Oct 2025 14:52:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF6D13858C83 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=5VvpKNRD Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010030.outbound.protection.outlook.com [52.101.46.30]) by sourceware.org (Postfix) with ESMTPS id 3B0DE3858D2A for ; Thu, 30 Oct 2025 14:51:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B0DE3858D2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3B0DE3858D2A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.46.30 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1761835899; cv=pass; b=iw5SSpZKFep2Ebm5T6+q2Uh1HI/ADWNzDzVP8A+tJK1NWkenIUuAXWEAc+AQ/4WWtp9owxkisdkC97d/+vnKZueKJ8ViO7FU4x4iYN5XF/f7NJNZohmW8X7FPXHllkdTwwtEZoWzCCLeLVLVc9L8lc09IRcabEMjFH8EtSoeoV8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1761835899; c=relaxed/simple; bh=jUZQEFDbczKhZwiA6bwCRy9NxfQSpckLLCK9/f+k1qQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rej0iOzD+k/UHxpKq1aI01VmS6lYnGmBBhy2cMcBMtzVj3E8BViJ9TJW0DDmm0quYyeeVYPjROjODRBpWaIYRoryE6nhgS1rDCHkc0IFuRvAGQC7m/9dml+FoLqR/7rjxcQxDpL9ebK5PApomSegtjrq3mhm2cjFOGXotLTR3R0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B0DE3858D2A ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gHZHrXCLEqjFJkDoY43mLkHKJmixMamcMX6sQkFgEURXrI1WpRCm+rz2PdSYuydiCyjOVIvobLR9J8JwjDLB/p7y3Tmkl6VXKxf9dAt3rRD7YcxePLQzqN+rHRg4UMby17GHqangoZ08Ow8jO0DISo7VxZopDc6S66+mc134vAPNYa4Hm9YmUGZBC9cqUeJ/jXpHHB35P+4vYzrH1dEYYM9UcA+F0IS+EJMX/XpTEFuMyZ3rRMUDr4NCDm5o44KIg14zS7GWbmeKaBxqIfcMjpCidB5SXS08ybh1gSSdAps3hIauZ1GW9tMy6kq6Wdb3eseXsfGMihAHfF1IvDgGxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4nv714o6mTI1WRRpA4jsL4o8PoOrWd/5wtB0sFZqBgc=; b=eyNoy7a19T0ipzxCmG3aolzPV0R/GLKKdUW2j5hbZFgzh83H/2vl1efEYHWE3Np1cRugoxpv5hMVczZbD/LuMRLGDuUdnchk91Z4cb46GM6T/ca5RzyzfhWnW1dfT9GB9ivIUnvsav5EB+EiYuMWlXtsVngSiccYuHNnBZfFl9+TmmJT130KgQdKb/+Huuwa5j1dFq3GbCYf19RLb3pSZmEAHNFXHWQcEQDHQmxy+NOwUbjFZYEZsVDYTBv/drLOqfJKnzXlMKnaJJkp+lfaUj4gXEZ7v2HFuy1COfWWxs1rizln7hsJqhxPYyC4yewJ1nPAJocBmWQEwR4HydmHFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4nv714o6mTI1WRRpA4jsL4o8PoOrWd/5wtB0sFZqBgc=; b=5VvpKNRDKyGdVOdGpUO4sDrJGtevq2gNx7zjgqJvO5l/bmZyYqDzL52UeN6Lyyc3KYP/DBR1zNju1qoi/jAbtaUqKuHJH6TvrnVkgc0NaHJQx0zuHYbcsx/MgEOZ17fosngiEY7by7teOryYxPvvKY9fGgqtmgr8hXqJt6caMWA= Received: from SA9P223CA0024.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::29) by PH7PR12MB5854.namprd12.prod.outlook.com (2603:10b6:510:1d5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.14; Thu, 30 Oct 2025 14:51:34 +0000 Received: from SA2PEPF00003AEA.namprd02.prod.outlook.com (2603:10b6:806:26:cafe::62) by SA9P223CA0024.outlook.office365.com (2603:10b6:806:26::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9253.18 via Frontend Transport; Thu, 30 Oct 2025 14:51:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SA2PEPF00003AEA.mail.protection.outlook.com (10.167.248.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.10 via Frontend Transport; Thu, 30 Oct 2025 14:51:34 +0000 Received: from khazad-dum (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 30 Oct 2025 07:51:32 -0700 Date: Thu, 30 Oct 2025 14:51:24 +0000 From: Lancelot SIX To: Luis Machado , Subject: Re: [PATCH] Fix device index in gdb.rocm/addr-bp-gpu-no-deb-info.exp Message-ID: References: <20251030095404.422806-1-luis.machado@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20251030095404.422806-1-luis.machado@amd.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003AEA:EE_|PH7PR12MB5854:EE_ X-MS-Office365-Filtering-Correlation-Id: 649e9bb4-65f8-41a9-4192-08de17c3d21e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+g3RMv+5huQugGiwrRfBBssuGln8SYdqtqDeBV1jaxmXBrLkH3KzLnwKiCVP?= =?us-ascii?Q?nlwzj2TcqQI2Jq/51+4bmHeuVtRZ19YyZn80jRpbduKg5RA67Axq7Qa9CGUt?= =?us-ascii?Q?f9NkmBdRSfbYSVA4OvFc2I8nOcaH03b67nfLl0Pniab9IfMWyfpQThHd9RqQ?= =?us-ascii?Q?6X9xJojhvcF3bYbfIjCqcaOiIcrolAguiL3MCUkIKxdXrC+ulhm8lI7YT0XJ?= =?us-ascii?Q?5v5Xfy97KX44KyBgbDdQkuqEFtokBnwi0VJc9P5ymgAgbsvkjZ/Z4lOKxqLI?= =?us-ascii?Q?igr/uIEqSiMVCIWtxDDfRz5Mb3JqDU+DCTw8b2CYOwI0rBweayBh1i1SM8Sp?= =?us-ascii?Q?gzIAxZIlKjJL0FOFclEKL1QPGaXyvSmbeiSTPvaD3kEqYu4gYmNXzvSEf2Ad?= =?us-ascii?Q?NurWdNVQVR3buun+qBWyWquACte7JuJQvWu0HJ5tyufli9ShDtAIiVEMq6TL?= =?us-ascii?Q?YedYEuIc+ikAfWZYCfuL1X0sKzlvHTUwQ4SYTrXIIXJVg6se2i/IBpBoYxDr?= =?us-ascii?Q?q++iXC83LnLGGS6ADsguhHFwCGcDgDJZxgyP32LKnmOWzOKCWfHzqNikTFpm?= =?us-ascii?Q?HwEfnccc/37yaMnkaPqC8gAvDSTnziDdRDI1JnwCS1dTJIn1W/qfarqDBv9Z?= =?us-ascii?Q?YhjByGa/fligIe2JA1+5pC92PBbq7ED+ldj5FCTdRwTktToXkVQKM5Bwpz+G?= =?us-ascii?Q?4N1KRSNjcarTv1q1RLnjZXumhvlEAzUcTkT2vQrV9Pta3JIDzSz99qNhHqG5?= =?us-ascii?Q?pkbL6YRtKxgZqpVwN+d45PC4KQbKFntMmB/av5ceI9t1lOzlNyb8QqvjBrkV?= =?us-ascii?Q?0T7pvVwrAGvfy529pWkKFlMZQUGTxjT9EglAxL9g1zGCNfz7PwQCGBviu5UO?= =?us-ascii?Q?8vHdybqj4lpPAUp42gGB5PT1Dxn//gqj6CogXZXHlVNRyXD5PZ8JURZOyM1W?= =?us-ascii?Q?Gzt/wl7SyeeXP80kmk9gvwEeDTOYqhDi3P2xLe80y3syFke+52U1VvgC3hNb?= =?us-ascii?Q?r4sWuORk+nMfiWBWDo73Dh4y7qTrUP/kJNeGQHkeTWL3g5n216f2HASQx1EO?= =?us-ascii?Q?bB1TDIqII7Xqtox5u+m/0TF+sfFjEvDIo98yCUdc57zk4D0sJko05Yov8hxB?= =?us-ascii?Q?0+UmPV/jyL5CRLMcDqkELmGZCWtdk+icQYEItK/RJyahhdVxagg2tYhw9NMQ?= =?us-ascii?Q?sQ3NFlYHdHs4dIffGeDx29MwP+0vdBPx1+vaJvddguzUr1GYSQ4+zKjg5vfa?= =?us-ascii?Q?PnQ7pObSWzH2y0oj5E/DQDQns8KzUMdnGSGENK3NAHbaCp0ten4l4R9gD6j2?= =?us-ascii?Q?PXM1WBh9Vu0vXsOIIKVI8j7aVthOTWMbPXc7jcu2VTpRfOzWNx4crPnFw8VO?= =?us-ascii?Q?CH6+wKWe6ssXJlgsffNK4O3HYjpc43+h2FnmZ53s2hgBQCfMTAcrmDPvpHqB?= =?us-ascii?Q?B0kQHrLFXG3P9HFCEmieFMJqfLbCiFGSx1NoEPBRirgCmua7LGlZ6fOoTBNX?= =?us-ascii?Q?+4gqqaMC9tzym7TqqDkUD7g9kyoqdavNhZFh?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2025 14:51:34.3780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 649e9bb4-65f8-41a9-4192-08de17c3d21e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003AEA.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5854 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, Oct 30, 2025 at 09:54:04AM +0000, Luis Machado wrote: > On a system with a single GPU, I spotted this test failing. The environment > variable ROCR_VISIBLE_DEVICES can be a bit misleading, as it actually expects > a list of device id's as opposed to a literal number of devices to make > visible. > > This test sets it to 1, which is the second GPU on the system. As a result, > systems with a single GPU will have no visible GPU's and the test will FAIL. > > Set ROCR_VISIBLE_DEVICES to 0 to make use of the first GPU on the system. > This looks good to me, thanks for fixing this. Approvid-by: Lancelot Six (AMDGPU) Best, Lancelot. > --- > gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp b/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp > index be459673dc9..2719f0d8b13 100644 > --- a/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp > +++ b/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp > @@ -28,9 +28,10 @@ if {[build_executable "failed to prepare" $testfile $srcfile {hip}]} { > > clean_restart $::testfile > > -# We may have multiple GPUs, resulting in many possible locations. This is > -# needed to ensure we get a single address to break on. > -gdb_test_no_output "set environment ROCR_VISIBLE_DEVICES=1" > +# We may have multiple GPUs, resulting in many possible locations. This is > +# needed to ensure we get a single address to break on, so make device 0 the > +# only visible one. > +gdb_test_no_output "set environment ROCR_VISIBLE_DEVICES=0" > > # Make the HIP runtime load all the GPU code objects during initialization. > gdb_test_no_output "set environment HIP_ENABLE_DEFERRED_LOADING=0" > -- > 2.43.0