From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59998-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1516 invoked by alias); 15 Nov 2008 17:00:53 -0000
Received: (qmail 1175 invoked by uid 22791); 15 Nov 2008 17:00:51 -0000
X-Spam-Check-By: sourceware.org
Received: from ns1.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 15 Nov 2008 17:00:11 +0000
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id 0395F42966; 	Sat, 15 Nov 2008 18:00:08 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Michael Snyder <msnyder@vmware.com>, 	Eli Zaretskii <eliz@gnu.org>, 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] [patch] 'info symbol' to print more info
References: <20081114204617.A4A533A6B15@localhost> 	<491DF12A.5090903@vmware.com> 	<8ac60eac0811141406h4bb126c0sbd898e7d612f46dd@mail.gmail.com> 	<491E08BF.2050609@vmware.com> 	<8ac60eac0811150842x78206050t435c6f8c89ddc8ae@mail.gmail.com>
X-Yow: Quick, sing me the BUDAPEST NATIONAL ANTHEM!!
Date: Sat, 15 Nov 2008 23:35:00 -0000
In-Reply-To: <8ac60eac0811150842x78206050t435c6f8c89ddc8ae@mail.gmail.com> 	(Paul Pluzhnikov's message of "Sat, 15 Nov 2008 08:42:12 -0800")
Message-ID: <jevduoexgo.fsf@sykes.suse.de>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00389.txt.bz2

Paul Pluzhnikov <ppluzhnikov@google.com> writes:

> Index: maint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/maint.c,v
> retrieving revision 1.68
> diff -u -p -u -r1.68 maint.c
> --- maint.c	30 Oct 2008 20:35:30 -0000	1.68
> +++ maint.c	15 Nov 2008 15:01:17 -0000
> @@ -484,9 +484,19 @@ maintenance_translate_address (char *arg
>      sym = lookup_minimal_symbol_by_pc (address);
>  
>    if (sym)
> -    printf_filtered ("%s+%s\n",
> -		     SYMBOL_PRINT_NAME (sym),
> -		     pulongest (address - SYMBOL_VALUE_ADDRESS (sym)));
> +    {
> +      printf_filtered ("%s + %s",
> +		       SYMBOL_PRINT_NAME (sym),
> +		       pulongest (address - SYMBOL_VALUE_ADDRESS (sym)));
> +      if ((sect = SYMBOL_OBJ_SECTION(sym)))

Please move the assignment out of the condition.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."