From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42890-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29407 invoked by alias); 16 Feb 2006 22:04:40 -0000
Received: (qmail 29375 invoked by uid 22791); 16 Feb 2006 22:04:37 -0000
X-Spam-Check-By: sourceware.org
Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Feb 2006 22:04:34 +0000
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id 4E5DEE689 	for <gdb-patches@sourceware.org>; Thu, 16 Feb 2006 23:04:31 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: RFC: Fix an infinite loop placing sections in relocatable objects
References: <20060216152444.GA22371@nevyn.them.org>
X-Yow: When you get your PH.D. will you get able to work at BURGER KING?
Date: Thu, 16 Feb 2006 22:04:00 -0000
In-Reply-To: <20060216152444.GA22371@nevyn.them.org> (Daniel Jacobowitz's 	message of "Thu, 16 Feb 2006 10:24:44 -0500")
Message-ID: <jeu0az7yfk.fsf@sykes.suse.de>
User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00328.txt.bz2

Daniel Jacobowitz <drow@false.org> writes:

> diff -u -p -r1.167 symfile.c
> --- symfile.c	7 Feb 2006 19:40:30 -0000	1.167
> +++ symfile.c	16 Feb 2006 15:21:43 -0000
> @@ -476,6 +476,7 @@ place_section (bfd *abfd, asection *sect
>    struct place_section_arg *arg = obj;
>    CORE_ADDR *offsets = arg->offsets->offsets, start_addr;
>    int done;
> +  ULONGEST align = 1 << bfd_get_section_alignment (abfd, sect);

I think bfd_get_section_alignment can return values bigger than 31 in
general, and this is undefined in this case.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."