From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47783-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12953 invoked by alias); 24 Feb 2007 21:44:57 -0000
Received: (qmail 12945 invoked by uid 22791); 24 Feb 2007 21:44:57 -0000
X-Spam-Check-By: sourceware.org
Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 24 Feb 2007 21:44:46 +0000
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id D9DA3122D3; 	Sat, 24 Feb 2007 22:44:42 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: Lerele <lerele@champenstudios.com>, Eli Zaretskii <eliz@gnu.org>, 	gdb-patches@sourceware.org
Subject: Re: [Patch] Win32 gdbserver new interrupt support, and attach to    process  fix.
References: <45DF7E27.10102@champenstudios.com> <ulkinvjx2.fsf@gnu.org> 	<45E0376D.9010605@champenstudios.com> <uejofvedj.fsf@gnu.org> 	<45E05872.1040605@champenstudios.com> 	<45E0AB9E.9060107@portugalmail.pt>
X-Yow: I want to kill everyone here with a cute colorful Hydrogen Bomb!!
Date: Sat, 24 Feb 2007 21:44:00 -0000
In-Reply-To: <45E0AB9E.9060107@portugalmail.pt> (Pedro Alves's message of 	"Sat, 24 Feb 2007 21:18:22 +0000")
Message-ID: <jetzxb6xjj.fsf@sykes.suse.de>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00303.txt.bz2

Pedro Alves <pedro_alves@portugalmail.pt> writes:

> Lerele wrote:
>> +/* Send a signal to the inferior process, however is appropriate. */
>> +static void
>> +win32_send_signal (int signo)
>> +{
>> +  if ( signo == TARGET_SIGNAL_INT )
>> +    {
>> +      if ( !GenerateConsoleCtrlEvent(CTRL_BREAK_EVENT, current_process_id) )
>>   
> Missing space: "GenerateConsoleCtrlEvent ("

And too many spaces.

+  if (signo == TARGET_SIGNAL_INT)
+    {
+      if (!GenerateConsoleCtrlEvent (CTRL_BREAK_EVENT, current_process_id))

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."