Re: Patch for isdigit/isalpha/etc. macro arguments

Andreas Schwab
2007-04-07T17:55:16Z

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andreas Schwab <schwab@suse.de>
>> Cc: mark.kettenis@xs4all.nl, sje@cup.hp.com,
>> gdb-patches@sourceware.org
>> Date: Sat, 07 Apr 2007 11:26:10 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> This will crash and burn if *s < 0. You really need to cast to unsigned
>> >> char if you want to get defined behaviour.
>> >
>> > Isn't that the job of the isalpha implementation?
>>
>> No. It needs to be able to recognize EOF.
>
> I don't see the problem with doing both.

How can it distinguish EOF from '\377'?

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃŸe 5, 90409 NÃ¼rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."