Re: Patch for isdigit/isalpha/etc. macro arguments

Andreas Schwab
2007-04-07T06:18:26Z

Mark Kettenis <mark.kettenis@xs4all.nl> writes:

> Bleach! So that's not a viable option. I think it's time to find the
> magic gcc option to turn the warning off. I mean
>
> char *s = "...";
> isalpha(*s);
>
> is perfectly reasonable code and should not result in compiler
> warnings.

This will crash and burn if *s < 0. You really need to cast to unsigned
char if you want to get defined behaviour.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃŸe 5, 90409 NÃ¼rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."