From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29696 invoked by alias); 22 Nov 2002 16:35:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29688 invoked from network); 22 Nov 2002 16:35:08 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 22 Nov 2002 16:35:08 -0000 Received: from Hermes.suse.de (Charybdis.suse.de [213.95.15.201]) by Cantor.suse.de (Postfix) with ESMTP id A3F2A149AB; Fri, 22 Nov 2002 17:35:07 +0100 (MET) X-Authentication-Warning: sykes.suse.de: schwab set sender to schwab@suse.de using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: m68k_register_virtual_type References: <3DDE4E31.4010807@redhat.com> X-Yow: YOW!! What should the entire human race DO?? Consume a fifth of CHIVAS REGAL, ski NUDE down MT. EVEREST, and have a wild SEX WEEKEND! From: Andreas Schwab Date: Fri, 22 Nov 2002 08:35:00 -0000 In-Reply-To: <3DDE4E31.4010807@redhat.com> (Andrew Cagney's message of "Fri, 22 Nov 2002 10:33:05 -0500") Message-ID: User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (ia64-suse-linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2002-11/txt/msg00545.txt.bz2 Andrew Cagney writes: |> Just FYI, |> |> > static struct type * |> > m68k_register_virtual_type (int regnum) |> > { |> > - if ((unsigned) regnum >= E_FPC_REGNUM) |> > + if (regnum == E_FPI_REGNUM) |> > return lookup_pointer_type (builtin_type_void); |> |> There are now: |> builtin_type_void_data_ptr |> builtin_type_void_code_ptr |> available. Thanks, I'll change that (it's actually builtin_type_void_func_ptr). |> > + else if ((unsigned) regnum >= E_FPC_REGNUM) |> > + return builtin_type_int; |> |> builtin_type_int32 is better |> |> > else if ((unsigned) regnum >= FP0_REGNUM) |> > return builtin_type_long_double; |> > + else if (regnum == PS_REGNUM) |> > + return builtin_type_int |> |> Ditto. What about the default case for the d0-d7 registers? Should it be changed to builtin_type_int32 as well? Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."