Re: [patch] "single step" atomic instruction sequences as a whole.

Daniel Jacobowitz
2007-04-10T20:40:18Z

On Thu, Mar 15, 2007 at 07:24:14PM -0300, Luis Machado wrote:
> I am aware that Emi is currently working on a similar patch, based on
> Paul's also. But since this is an issue that's been rolling for long and
> that negatively impacts on more specific debugging activities, wouldn't
> it be possible to include this patch as a fix while we wait for Emi's
> copyright assignment to be ready? After his copyright assignment is
> ready, it would be possible for him to incorporate additional changes
> that he wrote on top of this one.

I agree. However, the patch can't be applied as-is. There are a
couple of cosmetic issues, and at least one syntax error ("return 1",
no semicolon). Let's do it in two pieces, please.

Could you post a patch which changes the type of the
software_single_step gdbarch method to return int, updates infrun.c,
and nothing else? Then we can look at the PowerPC bits (which are
more interesting) separately.

When you're editing a bunch of tdep files, please use the
gdb_mbuild.sh script to make sure they all still compile.

--
Daniel Jacobowitz
CodeSourcery