From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47924-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17541 invoked by alias); 6 Mar 2007 11:00:31 -0000
Received: (qmail 17531 invoked by uid 22791); 6 Mar 2007 11:00:30 -0000
X-Spam-Check-By: sourceware.org
Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Mar 2007 11:00:25 +0000
Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id 4569D122AB; 	Tue,  6 Mar 2007 12:00:23 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: Emi SUZUKI <emi-suzuki@tjsys.co.jp>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] "single step" atomic instruction sequences as a whole.
References: <20070228.170713.193706115.emi-suzuki@tjsys.co.jp> 	<20070228114545.GB4620@caradoc.them.org> 	<1172678940.20041.13.camel@localhost> 	<20070302.214729.183026252.emi-suzuki@tjsys.co.jp>
X-Yow: ..  hubub, hubub, HUBUB, hubub, hubub, hubub, HUBUB, hubub, hubub, hubub.
Date: Tue, 06 Mar 2007 11:00:00 -0000
In-Reply-To: <20070302.214729.183026252.emi-suzuki@tjsys.co.jp> (Emi SUZUKI's 	message of "Fri, 02 Mar 2007 21:47:29 +0900 (JST)")
Message-ID: <jeps7m3ad6.fsf@sykes.suse.de>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-03/txt/msg00055.txt.bz2

Emi SUZUKI <emi-suzuki@tjsys.co.jp> writes:

> +  /* Assume that the atomic sequence ends with a stwcx instruction
> +     followed by a conditional branch instruction. */
> +  if ((insn & STWCX_MASK) != STWCX_INSTRUCTION)
> +    error (_("Tried to step over an atomic sequence of instructions but could not find the end of the sequence."));

I don't think error should be called here.  It would probably be better to
just continue with the normal single-step here.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."