From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24662 invoked by alias); 22 Nov 2002 17:05:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24654 invoked from network); 22 Nov 2002 17:05:19 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 22 Nov 2002 17:05:19 -0000 Received: from Hermes.suse.de (Charybdis.suse.de [213.95.15.201]) by Cantor.suse.de (Postfix) with ESMTP id 3D06C1488F; Fri, 22 Nov 2002 18:05:19 +0100 (MET) X-Authentication-Warning: sykes.suse.de: schwab set sender to schwab@suse.de using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: m68k_register_virtual_type References: <3DDE4E31.4010807@redhat.com> <3DDE6120.4010205@redhat.com> X-Yow: It's 74 degrees, 12 minutes NORTH, and 41 degrees, 3 minutes EAST!! Soon, it will be TUESDAY!! From: Andreas Schwab Date: Fri, 22 Nov 2002 09:05:00 -0000 In-Reply-To: <3DDE6120.4010205@redhat.com> (Andrew Cagney's message of "Fri, 22 Nov 2002 11:53:52 -0500") Message-ID: User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (ia64-suse-linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2002-11/txt/msg00547.txt.bz2 Andrew Cagney writes: |> > |> > + else if ((unsigned) regnum >= E_FPC_REGNUM) |> > |> > + return builtin_type_int; |> > |> |> builtin_type_int32 is better |> > |> |> > else if ((unsigned) regnum >= FP0_REGNUM) |> > |> > return builtin_type_long_double; |> > |> > + else if (regnum == PS_REGNUM) |> > |> > + return builtin_type_int |> > |> |> Ditto. |> > What about the default case for the d0-d7 registers? Should it be |> > changed |> > to builtin_type_int32 as well? |> |> Er, yes. (And eventually long_double to builtin_type_m68881_ext but the |> last one might have fallout related to register conversions). What kind of fallout could that be? Some quick tests didn't reveal anything obvious. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."