From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58734-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25722 invoked by alias); 20 Sep 2008 19:57:18 -0000
Received: (qmail 25712 invoked by uid 22791); 20 Sep 2008 19:57:18 -0000
X-Spam-Check-By: sourceware.org
Received: from ns1.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 20 Sep 2008 19:56:39 +0000
Received: from Relay1.suse.de (relay-ext.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id 703634178C; 	Sat, 20 Sep 2008 21:56:36 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: jeremy.bennett@embecosm.com
Cc: gdb-patches@sourceware.org
Subject: Re: Patch to update gdbint.texinfo [00/05]
References: <1221919290.2827.495.camel@thomas> <umyi2px4a.fsf@gnu.org> 	<1221935896.2827.545.camel@thomas>
X-Yow: I'm totally DESPONDENT over the LIBYAN situation and the price of CHICKEN..
Date: Sat, 20 Sep 2008 19:57:00 -0000
In-Reply-To: <1221935896.2827.545.camel@thomas> (Jeremy Bennett's message of 	"Sat, 20 Sep 2008 19:38:16 +0100")
Message-ID: <jek5d6a8wb.fsf@sykes.suse.de>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-09/txt/msg00445.txt.bz2

Jeremy Bennett <jeremy.bennett@embecosm.com> writes:

>> > +  if( 0 == n ) @{
>> > +    return 1;
>> > +  @}
>> > +  else @{
>> > +    return n * fact( n - 1 );
>> > +  @}
>> 
>> This is not the GNU style of formatting C code.  Please use the GNU
>> style.
>
> This was deliberate - the diagram has the code squashed up like this, so
> it fits in the space available, and I've used the text from the diagram
> literally. I can use GNU style in the text, but the diagram will have to
> use squashed up code.

You could at least fix the horizontal whitespace.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."