From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22756 invoked by alias); 23 Jun 2005 09:22:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22707 invoked by uid 22791); 23 Jun 2005 09:21:57 -0000 Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 23 Jun 2005 09:21:57 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 49FD2EE62; Thu, 23 Jun 2005 11:21:55 +0200 (CEST) From: Andreas Schwab To: Chad Harrington Cc: gdb-patches@sources.redhat.com Subject: Re: typo in gdb/gdb_ptrace.c References: X-Yow: I am having FUN... I wonder if it's NET FUN or GROSS FUN? Date: Thu, 23 Jun 2005 09:22:00 -0000 In-Reply-To: (Chad Harrington's message of "Wed, 22 Jun 2005 23:39:13 -0600") Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2005-06/txt/msg00357.txt.bz2 Chad Harrington writes: > Below is the diff patch for my fix. It is not critical, but it sure > looks like a mistake to me. This was in gdb-6.3, as you can see. The > preprocessor is told to define PT_ATTACH if PTRACE_DETACH is defined. > I think it should only define PT_ATTACH if PTRACE_ATTACH is defined, > but I think they'd both be defined if one or the other is already > defined anyway... It merely appears to be a typo. :-) There is another typo in the previous line. I've checked this in as obvious. 2005-06-23 Andreas Schwab * gdb_ptrace.h: Fix typos when checking for PT_ATTACH. Reported by Chad Harrington . --- gdb/gdb_ptrace.h.~1.3.~ 2004-11-22 13:57:48.000000000 +0100 +++ gdb/gdb_ptrace.h 2005-06-23 11:02:57.000000000 +0200 @@ -92,8 +92,8 @@ /* Not all systems support attaching and detaching. */ -#ifndef PT_ATTCH -# ifdef PTRACE_DETACH +#ifndef PT_ATTACH +# ifdef PTRACE_ATTACH # define PT_ATTACH PTRACE_ATTACH # endif #endif Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."