From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22297 invoked by alias); 16 Jul 2006 18:57:58 -0000 Received: (qmail 22289 invoked by uid 22791); 16 Jul 2006 18:57:58 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Jul 2006 18:57:55 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 654B21EC38; Sun, 16 Jul 2006 20:42:36 +0200 (CEST) From: Andreas Schwab To: pgilliam@us.ibm.com Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [patch] Fixes problem setting breakpoint in dynamic loader References: <1148513171.315.104.camel@dufur.beaverton.ibm.com> <200606172021.k5HKL82O013629@elgar.sibelius.xs4all.nl> <1152143843.6282.49.camel@dufur.beaverton.ibm.com> X-Yow: I know th'MAMBO!! I have a TWO-TONE CHEMISTRY SET!! Date: Sun, 16 Jul 2006 18:57:00 -0000 In-Reply-To: <1152143843.6282.49.camel@dufur.beaverton.ibm.com> (PAUL GILLIAM's message of "Wed, 05 Jul 2006 16:57:23 -0700") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00183.txt.bz2 PAUL GILLIAM writes: > + if (sym_addr != 0) > + /* Convert 'sym_addr' from a function pointer to an address. */ > + sym_addr = gdbarch_convert_from_func_ptr_addr (current_gdbarch, > + sym_addr, > + tmp_bfd_target); Why do you call gdbarch_convert_from_func_ptr_addr here? This is already called by adjust_breakpoint_address via ppc64_sysv_abi_adjust_breakpoint_address when setting the breakpoint. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."