From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13360 invoked by alias); 27 Jun 2004 22:59:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13353 invoked from network); 27 Jun 2004 22:59:20 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sourceware.org with SMTP; 27 Jun 2004 22:59:20 -0000 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 336B77E61EC; Mon, 28 Jun 2004 00:53:44 +0200 (CEST) To: Ulrich Weigand Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix frame ID comparison problem on s390 References: <40D08438.8090009@gnu.org> <200406272047.WAA10464@faui1m.informatik.uni-erlangen.de> <20040627214831.GA30684@nevyn.them.org> From: Andreas Schwab X-Yow: Now, my ENTIRE LIFE is flashing before my EYES as I park my DODGE DART in your EXXON service area for a COMPLETE LUBRICATION!! Date: Sun, 27 Jun 2004 22:59:00 -0000 In-Reply-To: <20040627214831.GA30684@nevyn.them.org> (Daniel Jacobowitz's message of "Sun, 27 Jun 2004 17:48:31 -0400") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2004-06/txt/msg00620.txt.bz2 Daniel Jacobowitz writes: >> + /* Flags to indicate the above fields have valid contents. */ >> + int stack_addr_p : 1; >> + int code_addr_p : 1; >> + int special_addr_p : 1; >> }; >> >> /* Methods for constructing and comparing Frame IDs. > > Some future version of GCC will warn about this mistake. The only > valid values for "int : 1" are 0 and -1. Actually it can be both 0/-1 and 0/1, since it is implementation defined whether unadorned int bitfields are signed or unsigned. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."