Re: [commit] Properly cast sentinels for concat()

Eli Zaretskii
2005-07-05T20:03:39Z

> Date: Tue, 5 Jul 2005 09:28:56 +0200
> From: Mark Kettenis <kettenis@jive.nl>
> CC: gdb-patches@sourceware.org
>
> But in Mark's case, NULL is defined as (void *)0, so it's a pointer,
> not an int.
>
> No it isn't, OpenBSD has
>
> #define NULL 0L

Sorry, I got confused: you did mention `void *', but that was about
the GCC version of stddef.h.

> Not that I think that it is a good thing, but Andrew has been talking
> about making GDB compilable with a C++ compiler before.

I never understood why we should waste any efforts on that.

> Do you still want me to revert the patch?

Well, let's say that I dislike those casts very much. So if there's
any reasonable chance to get the maintainers of OpenBSD and the
OpenBSD GCC port to fix this problem in the forseeble future, I'd
suggest to revert it. If not, I'll yield.