From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5036 invoked by alias); 5 May 2007 11:02:50 -0000 Received: (qmail 5027 invoked by uid 22791); 5 May 2007 11:02:49 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 05 May 2007 11:02:47 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 3E80321612; Sat, 5 May 2007 13:02:37 +0200 (CEST) From: Andreas Schwab To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: ColdFire/fido support References: <200705051337.02114.vladimir@codesourcery.com> X-Yow: Where's the Coke machine? Tell me a joke!! Date: Sat, 05 May 2007 11:02:00 -0000 In-Reply-To: <200705051337.02114.vladimir@codesourcery.com> (Vladimir Prus's message of "Sat\, 5 May 2007 13\:37\:01 +0400") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00059.txt.bz2 Vladimir Prus writes: > + /* Is this ColdFire architecture, as opposed to generic m68k? */ > + int coldfire; > + > + /* Is this fido architecture, as opposed to generic m68k? */ > + int fido; How about making this a single enum? They surely can never both be non-zero at the same time. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."