From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4936 invoked by alias); 16 Apr 2008 22:40:48 -0000 Received: (qmail 4924 invoked by uid 22791); 16 Apr 2008 22:40:46 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Apr 2008 22:40:26 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 6C74A4533C for ; Thu, 17 Apr 2008 00:40:23 +0200 (CEST) From: Andreas Schwab To: gdb-patches@sourceware.org Subject: Re: [rfc, rfa/doc] Multi-threaded watchpoint improvements References: <20070916183949.GA23966@caradoc.them.org> <20071001002015.GA15835@caradoc.them.org> X-Yow: I am NOT a nut.... Date: Wed, 16 Apr 2008 22:57:00 -0000 In-Reply-To: <20071001002015.GA15835@caradoc.them.org> (Daniel Jacobowitz's message of "Sun, 30 Sep 2007 20:20:15 -0400") Message-ID: User-Agent: Gnus/5.110008 (No Gnus v0.8) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00315.txt.bz2 Daniel Jacobowitz writes: > 2007-09-30 Daniel Jacobowitz > Jeff Johnston > > * breakpoint.c (watchpoints_triggered): New. > (bpstat_stop_status): Remove STOPPED_BY_WATCHPOINT argument. > Check watchpoint_triggered instead. Combine handling for software > and hardware watchpoints. Do not use target_stopped_data_address > here. Always check a watchpoint if its scope breakpoint triggers. > Do not stop for thread or overlay events. Improve check for > triggered watchpoints without a value change. > (watch_command_1): Insert the scope breakpoint first. Link the > scope breakpoint to the watchpoint. > * breakpoint.h (enum watchpoint_triggered): New. > (struct breakpoint): Add watchpoint_triggered. > (bpstat_stop_status): Update prototype. > (watchpoints_triggered): Declare. > * infrun.c (enum infwait_status): Add infwait_step_watch_state. > (stepped_after_stopped_by_watchpoint): Delete. > (handle_inferior_event): Make stepped_after_stopped_by_watchpoint > local. Handle infwait_step_watch_state. Update calls to > bpstat_stop_status. Use watchpoints_triggered to check > watchpoints. > * remote.c (stepped_after_stopped_by_watchpoint): Remove extern. > (remote_stopped_data_address): Do not check it. That completely broke watchpoints on ppc. They are no longer recognized as such, and gdb is reporting a SIGTRAP instead. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."