Re: [patch] Disable child VMA randomizations

[Andreas Schwab <schwab@suse.de>]

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> +dnl Check if we can disable the virtual address space randomization.
> +dnl The functionality of setarch -R.
> +define([PERSONALITY_TEST], [AC_LANG_PROGRAM([#include <sys/personality.h>],
> +    [#define PERSONALITY_ADDR_NO_RANDOMIZE 0x0040000
> +    /* Test the flag could be set and stays set.  */
> +    personality (personality (0xffffffff) | PERSONALITY_ADDR_NO_RANDOMIZE);
> +    if (!(personality (personality (0xffffffff))
> +	  & PERSONALITY_ADDR_NO_RANDOMIZE))
> +	return 1])])
> +AC_RUN_IFELSE(PERSONALITY_TEST,
> +    AC_DEFINE([HAVE_PERSONALITY], 1,
> +	      [Define if you support the personality syscall.]),
> +    ,
> +    AC_LINK_IFELSE(PERSONALITY_TEST,
> +	AC_DEFINE([HAVE_PERSONALITY], 1,
> +		  [Define if you support the personality syscall.])))

This is underquoted.  All arguments containing nested macro invocations
should be quoted.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."