From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58775-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19736 invoked by alias); 24 Sep 2008 12:18:29 -0000
Received: (qmail 19720 invoked by uid 22791); 24 Sep 2008 12:18:28 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Sep 2008 12:17:49 +0000
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id 8332A416C7; 	Wed, 24 Sep 2008 14:17:46 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Andrew Stubbs <ams@codesourcery.com>
Cc: gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [commited] Detect bad debug info
References: <48D3EC6C.8050809@codesourcery.com>
X-Yow: Sign my PETITION.
Date: Wed, 24 Sep 2008 12:18:00 -0000
In-Reply-To: <48D3EC6C.8050809@codesourcery.com> (Andrew Stubbs's message of 	"Fri, 19 Sep 2008 19:16:12 +0100")
Message-ID: <jeej39zqja.fsf@sykes.suse.de>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-09/txt/msg00486.txt.bz2

Andrew Stubbs <ams@codesourcery.com> writes:

> +  /* Detect bad debug info.  */
> +  maxsize = -offset;
> +  for (i = regnum; i < gdbarch_num_regs (gdbarch); i++)

This is broken, it completely ignores the pseudo regs, which badly
breaks ia64 and many other targets.  Committed as obvious.

Andreas.

2008-09-24  Andreas Schwab  <schwab@suse.de>

	* frame.c (get_frame_register_bytes): Take pseudo registers into
	account.

--- frame.c.~1.253.~	2008-09-23 11:46:45.000000000 +0200
+++ frame.c	2008-09-24 14:09:33.000000000 +0200
@@ -809,7 +809,8 @@ get_frame_register_bytes (struct frame_i
   /* Ensure that we will not read beyond the end of the register file.
      This can only ever happen if the debug information is bad.  */
   maxsize = -offset;
-  for (i = regnum; i < gdbarch_num_regs (gdbarch); i++)
+  for (i = regnum;
+       i < gdbarch_num_regs (gdbarch) + gdbarch_num_pseudo_regs (gdbarch); i++)
     {
       int thissize = register_size (gdbarch, i);
       if (thissize == 0)

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."