From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6900 invoked by alias); 18 Oct 2006 20:21:00 -0000 Received: (qmail 6892 invoked by uid 22791); 18 Oct 2006 20:20:59 -0000 X-Spam-Check-By: sourceware.org Received: from ns2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Oct 2006 20:20:52 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 2083A20CD1; Wed, 18 Oct 2006 22:20:44 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Cc: Andrew STUBBS , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't give spurious warnings when using thread specific breakpoints References: <452CF534.4060209@st.com> <20061011135545.GA26060@nevyn.them.org> <452D0385.6010103@st.com> <20061011204525.GA9622@nevyn.them.org> <45361793.1020202@st.com> <20061018141419.GA7771@nevyn.them.org> <4536444C.9020709@st.com> X-Yow: Actually, what I'd like is a little toy spaceship!! Date: Wed, 18 Oct 2006 20:21:00 -0000 In-Reply-To: (Eli Zaretskii's message of "Wed, 18 Oct 2006 21:47:39 +0200") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00234.txt.bz2 Eli Zaretskii writes: > No, you don't need to do that. Instead, you should rewrite the code > like this: > > ALL_BREAKPOINTS (b) > if (b->loc->address == pc) /* address match / overlay match */ > if (!b->pending && (!overlay_debugging || b->loc->section == section)) > { > others--; > if (others == 1 && > (b->enable_state == bp_disabled || > b->enable_state == bp_shlib_disabled || > b->enable_state == bp_call_disabled)) > printf_filtered (_("Note: breakpoint %d (disabled) also set at pc "), That won't work either. Some languages (notably German) need to put the verb at the end of the sentence in such a case. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."