From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-56261-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22561 invoked by alias); 22 May 2008 15:34:34 -0000
Received: (qmail 22550 invoked by uid 22791); 22 May 2008 15:34:33 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 22 May 2008 15:34:13 +0000
Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx2.suse.de (Postfix) with ESMTP id CA6F845F62 	for <gdb-patches@sourceware.org>; Thu, 22 May 2008 17:34:10 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: gdb-patches@sourceware.org
Subject: Fix frame-args.exp failure
X-Yow: ..  the MYSTERIANS are in here with my CORDUROY SOAP DISH!!
Date: Thu, 22 May 2008 21:26:00 -0000
Message-ID: <jed4nes68d.fsf@sykes.suse.de>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-05/txt/msg00662.txt.bz2

This fixes a testsuite failure on powerpc.  print_frame_args didn't
handle arguments that are optimized out (that can happen even in
unoptimized code).

Andreas.

2008-05-22  Andreas Schwab  <schwab@suse.de>

	* stack.c (print_frame_args): Handle LOC_OPTIMIZED_OUT.

testsuite/:
	* gdb.base/frame-args.exp: Handle arguments that are optimized
	out.

Index: gdb/stack.c
===================================================================
RCS file: /cvs/src/src/gdb/stack.c,v
retrieving revision 1.168
diff -u -a -p -r1.168 stack.c
--- gdb/stack.c	19 May 2008 15:50:10 -0000	1.168
+++ gdb/stack.c	22 May 2008 15:15:05 -0000
@@ -267,6 +267,7 @@ print_frame_args (struct symbol *func, s
 	    case LOC_LOCAL_ARG:
 	    case LOC_BASEREG_ARG:
 	    case LOC_COMPUTED_ARG:
+	    case LOC_OPTIMIZED_OUT:
 	      break;
 
 	    /* Other types of symbols we just skip over.  */
Index: gdb/testsuite/gdb.base/frame-args.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/frame-args.exp,v
retrieving revision 1.2
diff -u -a -p -r1.2 frame-args.exp
--- gdb/testsuite/gdb.base/frame-args.exp	1 Jan 2008 22:53:19 -0000	1.2
+++ gdb/testsuite/gdb.base/frame-args.exp	22 May 2008 15:15:08 -0000
@@ -41,7 +41,7 @@ gdb_test "set print frame-arguments all"
          "" \
          "set print frame-arguments all"
 gdb_test "frame 1" \
-         ".*in call_me \\(i=3, f=5, s={a = 3, b = 5}, ss=0x\[0-9a-f\]\+, u={.*}, e=green\\) at .*frame-args\\.c:.*" \
+         ".*in call_me \\(i=3, f=5, s=({a = 3, b = 5}|<value optimized out>), ss=0x\[0-9a-f\]\+, u=({.*}|<value optimized out>), e=green\\) at .*frame-args\\.c:.*" \
          "frame 1 with print frame-arguments set to all"
 
 # Test with "print frame-arguments" set to "scalars"

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."