Re: RFA: fix macro expansion bug

[Andreas Schwab <schwab@suse.de>]

Pedro Alves <pedro@codesourcery.com> writes:

> Though, I'm having a bit of trouble convincing myself that the logic to
> handle 'pp-number e|E|p|P|. sign' below is 100% sane.
>
> static int
> get_pp_number (struct macro_buffer *tok, char *p, char *end)
> {
> ...
>       while (p < end)
>         {
>           if (macro_is_digit (*p)
>               || macro_is_identifier_nondigit (*p)
>               || *p == '.')
>             p++;
>           else if (p + 2 <= end
>                    && strchr ("eEpP.", *p)
>                    && (p[1] == '+' || p[1] == '-'))
>             p += 2;
>           else
>             break;
>         }
>
> It seems macro_is_identifier_nondigit will always eat any of "eEpP",
> thus, say, when parsing "1e-" only "1e" will be identified as a pp
> number, leaving "+" in the stream.  Is this right?

Also, a sign can only follow [eEpP], but not [.].

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."