Re: [patch] Watchpoints: support for thread <thread_num> parameters

Daniel Jacobowitz
2007-08-20T14:21:57Z

On Mon, Aug 20, 2007 at 11:03:49AM -0300, Luis Machado wrote:
> On Fri, 2007-08-17 at 14:49 -0400, Daniel Jacobowitz wrote:
> > On Fri, Aug 17, 2007 at 09:41:38PM +0300, Eli Zaretskii wrote:
> > > Is this all that needs to be done to have thread-specific watchpoints?
> > > Do they work after this patch as you want them to?
> >
> > In my opinion, not really. On some systems, you can tell the target
> > layer which threads the watchpoint should be inserted for and spare
> > yourself extra stops in "wrong" threads.
>
> What do you have in mind regarding the whole feature? Will we head
> towards a different solution?

The work you've done will still be necessary. I have no plans to work
on the bigger picture, myself, but thread specificity needs to be
communicated to lower layers somehow.

Consider: in the current status quo the watchpoint would be inserted
in every thread, using up precious hardware debug resources and
triggering unnecessarily. We'll just resume in threads other than the
indicated one, so we shouldn't set up the watchpoint anywhere else.

--
Daniel Jacobowitz
CodeSourcery