From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30553 invoked by alias); 26 Feb 2003 21:26:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30545 invoked from network); 26 Feb 2003 21:26:20 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by 172.16.49.205 with SMTP; 26 Feb 2003 21:26:20 -0000 Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136]) by Cantor.suse.de (Postfix) with ESMTP id 247CE145AE; Wed, 26 Feb 2003 22:26:20 +0100 (MET) To: Kris Warkentin Cc: gdb-patches@sources.redhat.com Subject: Re: [Patch] correctly configure wcwidth in readline X-Yow: .. I see TOILET SEATS... From: Andreas Schwab Date: Wed, 26 Feb 2003 21:26:00 -0000 In-Reply-To: <20030226175141.GA15347@nevyn.them.org> (Daniel Jacobowitz's message of "Wed, 26 Feb 2003 12:51:41 -0500") Message-ID: User-Agent: Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.3.50 References: <00d101c2ddbd$6d3bfac0$0202040a@catdog> <20030226173758.GA14836@nevyn.them.org> <00e901c2ddbe$b23815e0$0202040a@catdog> <20030226175141.GA15347@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2003-02/txt/msg00748.txt.bz2 Daniel Jacobowitz writes: |> On Wed, Feb 26, 2003 at 12:44:22PM -0500, Kris Warkentin wrote: |> > Here's what seems to me to be a more elegant solution. In aclocal.m4, I |> > just define the obj as wcwidth.o and then the Makefile will either have it |> > or not. |> > |> > cheers, |> |> > < AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH)) |> > --- |> > > AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH), |> > AC_SUBST(WCWIDTH_OBJ,wcwidth.o)) |> |> [Always use unified or context diffs, please] |> |> Did you try this on a host with wcwidth? I don't think it'll work |> right; I have the feeling that a conditional AC_SUBST can leave |> @WCWIDTH_OBJ@ in the makefile. AC_SUBST is a kind of declaration, it's mere existence (as long as it is expanded by autoconf) causes the variable to be substituted. Only the assignment of the value happens at runtime. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."