From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25964 invoked by alias); 27 Jun 2003 23:05:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25957 invoked from network); 27 Jun 2003 23:05:24 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 27 Jun 2003 23:05:24 -0000 Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136]) by Cantor.suse.de (Postfix) with ESMTP id 282C714F35; Sat, 28 Jun 2003 01:05:24 +0200 (MEST) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] infcall.c cleanup - explict bp_addr variable References: <3EA6AE7F.7060708@redhat.com> <3EFCBF6F.2050805@redhat.com> From: Andreas Schwab X-Yow: I want a VEGETARIAN BURRITO to go.. with EXTRA MSG!! Date: Fri, 27 Jun 2003 23:05:00 -0000 In-Reply-To: <3EFCBF6F.2050805@redhat.com> (Andrew Cagney's message of "Fri, 27 Jun 2003 18:04:31 -0400") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2003-06/txt/msg00842.txt.bz2 Andrew Cagney writes: |> Does, instead, a s/push_arguments/push_dummy_call/ and move the above code |> to push_dummy_call (PC -> FUNC_ADDR, CALL_DUMMY_ADDRESS -> BP_ADDR) work? Yes, that seems to work. I'll prepare a patch that also replaces the deprecated read/write_register calls with the regcache functions. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."