From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25952 invoked by alias); 7 Apr 2007 09:26:19 -0000 Received: (qmail 25940 invoked by uid 22791); 7 Apr 2007 09:26:19 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 07 Apr 2007 10:26:14 +0100 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id A66E921611; Sat, 7 Apr 2007 11:26:11 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Cc: mark.kettenis@xs4all.nl, sje@cup.hp.com, gdb-patches@sourceware.org Subject: Re: Patch for isdigit/isalpha/etc. macro arguments References: <200704062336.QAA17806@hpsje.cup.hp.com> <200704062348.l36NmiwC025816@brahms.sibelius.xs4all.nl> X-Yow: When you get your PH.D. will you get able to work at BURGER KING? Date: Sat, 07 Apr 2007 09:26:00 -0000 In-Reply-To: (Eli Zaretskii's message of "Sat, 07 Apr 2007 12:16:32 +0300") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00042.txt.bz2 Eli Zaretskii writes: >> This will crash and burn if *s < 0. You really need to cast to unsigned >> char if you want to get defined behaviour. > > Isn't that the job of the isalpha implementation? No. It needs to be able to recognize EOF. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."