From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-48385-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8106 invoked by alias); 11 Apr 2007 08:47:47 -0000
Received: (qmail 8057 invoked by uid 22791); 11 Apr 2007 08:47:45 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Apr 2007 09:47:42 +0100
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id 803D4122E3; 	Wed, 11 Apr 2007 10:47:39 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: bonzini@gnu.org
Cc: Dave Korn <dave.korn@artimi.com>, 	'Steve Ellcey' <sje@cup.hp.com>, binutils@sourceware.org, 	gcc-patches@gcc.gnu.org, gdb-patches@gcc.gnu.org, 	newlib@sourceware.org, Ralf.Wildenhues@gmx.de, aoliva@redhat.com, 	libtool@cwilson.fastmail.fm
Subject: Re: Final(?) patch to update libtool in GCC and src trees
References: <006501c77bab$1753a410$2e08a8c0@CAM.ARTIMI.COM> 	<200704102006.NAA21177@hpsje.cup.hp.com> 	<008301c77bd6$7fa44bc0$2e08a8c0@CAM.ARTIMI.COM> 	<461C8FE6.9010800@lu.unisi.ch>
X-Yow: Yow!  Am I cleansed yet?!
Date: Wed, 11 Apr 2007 08:47:00 -0000
In-Reply-To: <461C8FE6.9010800@lu.unisi.ch> (Paolo Bonzini's message of "Wed, 	11 Apr 2007 09:36:06 +0200")
Message-ID: <je7isj5mc9.fsf@sykes.suse.de>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-04/txt/msg00133.txt.bz2

Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> Inside those two lines we have
>
> if test "${use_libtool}" = "yes"; then
> AC_LIBTOOL_WIN32_DLL
> AM_PROG_LIBTOOL
> AC_PROG_AWK
> fi
>
> I would rewrite them at the very least as
>
> AC_PROG_AWK
> AC_PROG_CXX
>
> if test "${use_libtool}" = "yes"; then
> AC_LIBTOOL_WIN32_DLL
> AM_PROG_LIBTOOL
> fi

I think that should use AS_IF instead.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."