From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14389 invoked by alias); 30 Jun 2007 15:36:05 -0000 Received: (qmail 14379 invoked by uid 22791); 30 Jun 2007 15:36:05 -0000 X-Spam-Check-By: sourceware.org Received: from ns1.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 30 Jun 2007 15:35:59 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id D07FD1226A; Sat, 30 Jun 2007 17:35:48 +0200 (CEST) From: Andreas Schwab To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: ColdFire/fido support References: <200705051337.02114.vladimir@codesourcery.com> <200705061552.15456.vladimir@codesourcery.com> <200705281542.47676.vladimir@codesourcery.com> X-Yow: I'm mentally OVERDRAWN! What's that SIGNPOST up ahead? Where's ROD STERLING when you really need him? Date: Sat, 30 Jun 2007 15:47:00 -0000 In-Reply-To: <200705281542.47676.vladimir@codesourcery.com> (Vladimir Prus's message of "Mon\, 28 May 2007 15\:42\:47 +0400") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00539.txt.bz2 Vladimir Prus writes: > + /* The mechanism for returning floating values from function > + and the type of long double depend on whether we're > + on ColdFire or standard m68k. */ > + > + if (info.bfd_arch_info) > + { > + const bfd_arch_info_type *coldfire_arch = > + bfd_lookup_arch (bfd_arch_m68k, bfd_mach_mcf_isa_a_nodiv); > + > + if (coldfire_arch > + && (*info.bfd_arch_info->compatible) > + (info.bfd_arch_info, coldfire_arch)) > + flavour = m68k_coldfire_flavour; > + } This always sets flavour to m68k_coldfire_flavour, since any m68k arch is always compatible with the generic m68k architecture. Andreas. 2007-06-30 Andreas Schwab * m68k-tdep.c (m68k_gdbarch_init): Don't infer coldfire flavour from the generic m68k arch. --- gdb/m68k-tdep.c.~1.120.~ 2007-06-19 11:04:57.000000000 +0200 +++ gdb/m68k-tdep.c 2007-06-30 17:26:39.000000000 +0200 @@ -1110,14 +1110,14 @@ m68k_gdbarch_init (struct gdbarch_info i and the type of long double depend on whether we're on ColdFire or standard m68k. */ - if (info.bfd_arch_info) + if (info.bfd_arch_info && info.bfd_arch_info->mach != 0) { const bfd_arch_info_type *coldfire_arch = bfd_lookup_arch (bfd_arch_m68k, bfd_mach_mcf_isa_a_nodiv); if (coldfire_arch - && (*info.bfd_arch_info->compatible) - (info.bfd_arch_info, coldfire_arch)) + && ((*info.bfd_arch_info->compatible) + (info.bfd_arch_info, coldfire_arch))) flavour = m68k_coldfire_flavour; } -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."