From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-48519-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29881 invoked by alias); 17 Apr 2007 18:57:36 -0000
Received: (qmail 29873 invoked by uid 22791); 17 Apr 2007 18:57:36 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Apr 2007 19:57:33 +0100
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx2.suse.de (Postfix) with ESMTP id 1EC7D215C3; 	Tue, 17 Apr 2007 20:57:31 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org, 	"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: Style fixes
References: <Pine.LNX.4.61.0704171728440.17222@perivale.mips.com> 	<20070417180313.GA9378@caradoc.them.org> 	<Pine.LNX.4.61.0704171906380.17222@perivale.mips.com>
X-Yow: My TOYOTA is built like a ... BAGEL with CREAM CHEESE!!
Date: Tue, 17 Apr 2007 19:18:00 -0000
In-Reply-To: <Pine.LNX.4.61.0704171906380.17222@perivale.mips.com> (Maciej 	W. Rozycki's message of "Tue, 17 Apr 2007 19:12:29 +0100 (BST)")
Message-ID: <je647uvnfp.fsf@sykes.suse.de>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-04/txt/msg00267.txt.bz2

"Maciej W. Rozycki" <macro@mips.com> writes:

> On Tue, 17 Apr 2007, Daniel Jacobowitz wrote:
>
>> > -	      int partial_len = (len < mips_abi_regsize (gdbarch)
>> > -				 ? len : mips_abi_regsize (gdbarch));
>> > +	      int partial_len = (len < mips_abi_regsize (gdbarch))
>> > +				? len : mips_abi_regsize (gdbarch);
>> 
>> These (and most of the others) were actually there for a reason.
>> Emacs will move that second line leftwards if there isn't an outer
>> layer of parentheses; I believe GNU Indent and gdb_indent.sh will also.
>
>  I can revert these, no problem -- it just looks strange and is not useful 
> from the language's point of view to have the right-hand side of an 
> assignment in brackets.

There are still redundant parens, and those are even less useful.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."