From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21223 invoked by alias); 16 Dec 2007 18:45:16 -0000 Received: (qmail 21215 invoked by uid 22791); 16 Dec 2007 18:45:16 -0000 X-Spam-Check-By: sourceware.org Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Dec 2007 18:45:10 +0000 Received: from Relay1.suse.de (relay-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 9EABC23018; Sun, 16 Dec 2007 19:45:07 +0100 (CET) From: Andreas Schwab To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Refactor bpstat_stop_status. References: <200712162115.00462.vladimir@codesourcery.com> X-Yow: After this, I'm going to BURN some RUBBER!! Date: Sun, 16 Dec 2007 18:46:00 -0000 In-Reply-To: <200712162115.00462.vladimir@codesourcery.com> (Vladimir Prus's message of "Sun\, 16 Dec 2007 21\:14\:59 +0300") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00210.txt.bz2 Vladimir Prus writes: > The bpstat_stop_status function is rather big today, > which makes it hard to do further changes. This patch > extracts bits of that function into separate functions. > No changes in behaviour are expected, and no regressions. OK? Could you please add a comment before each function that summerizes their purpose? Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."