From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6317 invoked by alias); 10 Jun 2008 11:58:13 -0000 Received: (qmail 6308 invoked by uid 22791); 10 Jun 2008 11:58:13 -0000 X-Spam-Check-By: sourceware.org Received: from ns2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Jun 2008 11:57:53 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id E1A8245ACA; Tue, 10 Jun 2008 13:57:50 +0200 (CEST) From: Andreas Schwab To: "Joseph S. Myers" Cc: Daniel Jacobowitz , gdb-patches@sourceware.org Subject: Re: --with-pkgversion and --with-bugurl support for GDB References: <20080605202431.GK25085@caradoc.them.org> X-Yow: Imagine--a WORLD without POODLES... Date: Tue, 10 Jun 2008 12:58:00 -0000 In-Reply-To: (Joseph S. Myers's message of "Thu, 5 Jun 2008 21:28:15 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00199.txt.bz2 "Joseph S. Myers" writes: > @@ -1154,6 +1154,13 @@ and \"show warranty\" for details.\n"); > fprintf_filtered (stream, "%s", host_name); > } > fprintf_filtered (stream, "\"."); > + > + if (REPORT_BUGS_TO[0]) > + { > + fprintf_filtered (stream, > + _("\nFor bug reporting instructions, please see:\n")); > + fprintf_filtered (stream, "%s.\n", REPORT_BUGS_TO); print_gdb_version is not supposed to print a final newline, see its uses in captured_main. Committed as obvious. Andreas. 2008-06-10 Andreas Schwab * top.c (print_gdb_version): Don't print final newline. --- gdb/top.c.~1.142.~ 2008-06-06 10:04:20.000000000 +0200 +++ gdb/top.c 2008-06-10 13:43:35.000000000 +0200 @@ -1159,7 +1159,7 @@ and \"show warranty\" for details.\n"); { fprintf_filtered (stream, _("\nFor bug reporting instructions, please see:\n")); - fprintf_filtered (stream, "%s.\n", REPORT_BUGS_TO); + fprintf_filtered (stream, "%s.", REPORT_BUGS_TO); } } -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."